Linux FSCRYPT development
 help / color / mirror / Atom feed
From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
To: ebiggers@kernel.org, tytso@mit.edu, jaegeuk@kernel.org,
	linux-fscrypt@vger.kernel.org, kernel-team@meta.com
Cc: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Subject: [PATCH v1 00/10] fscrypt: rearrangements preliminary to extent encryption
Date: Mon, 10 Apr 2023 06:16:21 -0400	[thread overview]
Message-ID: <cover.1681116739.git.sweettea-kernel@dorminy.me> (raw)

As per [1], extent-based encryption needs to split allocating and
preparing crypto_skciphers, since extent infos will be loaded at IO time
and crypto_skciphers cannot be allocated at IO time. 

This changeset undertakes to split the existing code to clearly
distinguish preparation and allocation of fscrypt_prepared_keys,
wrapping crypto_skciphers. Elegance of code is in the eye of the
beholder, but I've tried a decent variety of arrangements here and this
seems like the clearest result to me; happy to adjust as desired, and
more changesets coming soon, this just seemed like the clearest cutoff
point for preliminaries without being pure refactoring.

Patchset should apply cleanly to fscrypt/for-next, and pass ext4/f2fs tests
(kvm-xfstests is not currently succesfully setting up ubifs volumes for
me).

[1] https://lore.kernel.org/linux-btrfs/Y7NQ1CvPyJiGRe00@sol.localdomain/ 

Sweet Tea Dorminy (10):
  fscrypt: split and rename setup_file_encryption_key()
  fscrypt: split and rename setup_per_mode_enc_key()
  fscrypt: move dirhash key setup away from IO key setup
  fscrypt: reduce special-casing of IV_INO_LBLK_32
  fscrypt: make infos have a pointer to prepared keys
  fscrypt: move all the shared mode key setup deeper
  fscrypt: make ci->ci_direct_key a bool not a pointer
  fscrypt: make prepared keys record their type.
  fscrypt: explicitly track prepared parts of key
  fscrypt: split key alloc and preparation

 fs/crypto/crypto.c          |   2 +-
 fs/crypto/fname.c           |   4 +-
 fs/crypto/fscrypt_private.h |  73 +++++--
 fs/crypto/inline_crypt.c    |  30 +--
 fs/crypto/keysetup.c        | 379 ++++++++++++++++++++++++------------
 fs/crypto/keysetup_v1.c     |  13 +-
 6 files changed, 336 insertions(+), 165 deletions(-)


-- 
2.40.0


             reply	other threads:[~2023-04-10 10:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 10:16 Sweet Tea Dorminy [this message]
2023-04-10 10:16 ` [PATCH v1 01/10] fscrypt: split and rename setup_file_encryption_key() Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 02/10] fscrypt: split and rename setup_per_mode_enc_key() Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 03/10] fscrypt: move dirhash key setup away from IO key setup Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 04/10] fscrypt: reduce special-casing of IV_INO_LBLK_32 Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 05/10] fscrypt: make infos have a pointer to prepared keys Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 06/10] fscrypt: move all the shared mode key setup deeper Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 07/10] fscrypt: make ci->ci_direct_key a bool not a pointer Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 08/10] fscrypt: make prepared keys record their type Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 09/10] fscrypt: explicitly track prepared parts of key Sweet Tea Dorminy
2023-04-10 10:16 ` [PATCH v1 10/10] fscrypt: split key alloc and preparation Sweet Tea Dorminy
2023-04-10 19:19 ` [PATCH v1 00/10] fscrypt: rearrangements preliminary to extent encryption Eric Biggers
2023-04-10 19:40   ` Sweet Tea Dorminy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1681116739.git.sweettea-kernel@dorminy.me \
    --to=sweettea-kernel@dorminy.me \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox