* [syzbot] [hfs?] KMSAN: uninit-value in copy_name
@ 2024-05-18 9:21 syzbot
2024-05-21 5:21 ` [PATCH] hfsplus: fix " Edward Adam Davis
0 siblings, 1 reply; 8+ messages in thread
From: syzbot @ 2024-05-18 9:21 UTC (permalink / raw)
To: linux-fsdevel, linux-kernel, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: a5131c3fdf26 Merge tag 'x86-shstk-2024-05-13' of git://git..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=16035b70980000
kernel config: https://syzkaller.appspot.com/x/.config?x=64e100d74625a6a5
dashboard link: https://syzkaller.appspot.com/bug?extid=efde959319469ff8d4d7
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10314fbc980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11f47248980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/81edac548743/disk-a5131c3f.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/42f67aa888e5/vmlinux-a5131c3f.xz
kernel image: https://storage.googleapis.com/syzbot-assets/2e5cf5b3704d/bzImage-a5131c3f.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/08efa6c23198/mount_0.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com
=====================================================
BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
sized_strscpy+0xc4/0x160
copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
vfs_listxattr fs/xattr.c:493 [inline]
listxattr+0x1f3/0x6b0 fs/xattr.c:840
path_listxattr fs/xattr.c:864 [inline]
__do_sys_listxattr fs/xattr.c:876 [inline]
__se_sys_listxattr fs/xattr.c:873 [inline]
__x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Uninit was created at:
slab_post_alloc_hook mm/slub.c:3877 [inline]
slab_alloc_node mm/slub.c:3918 [inline]
kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065
kmalloc include/linux/slab.h:628 [inline]
hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699
vfs_listxattr fs/xattr.c:493 [inline]
listxattr+0x1f3/0x6b0 fs/xattr.c:840
path_listxattr fs/xattr.c:864 [inline]
__do_sys_listxattr fs/xattr.c:876 [inline]
__se_sys_listxattr fs/xattr.c:873 [inline]
__x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
CPU: 0 PID: 5047 Comm: syz-executor429 Not tainted 6.9.0-syzkaller-01768-ga5131c3fdf26 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
=====================================================
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] hfsplus: fix uninit-value in copy_name
2024-05-18 9:21 [syzbot] [hfs?] KMSAN: uninit-value in copy_name syzbot
@ 2024-05-21 5:21 ` Edward Adam Davis
2024-07-04 13:36 ` Dmitry Vyukov
2024-07-05 21:20 ` Kees Cook
0 siblings, 2 replies; 8+ messages in thread
From: Edward Adam Davis @ 2024-05-21 5:21 UTC (permalink / raw)
To: syzbot+efde959319469ff8d4d7; +Cc: linux-fsdevel, linux-kernel, syzkaller-bugs
[syzbot reported]
BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
sized_strscpy+0xc4/0x160
copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
vfs_listxattr fs/xattr.c:493 [inline]
listxattr+0x1f3/0x6b0 fs/xattr.c:840
path_listxattr fs/xattr.c:864 [inline]
__do_sys_listxattr fs/xattr.c:876 [inline]
__se_sys_listxattr fs/xattr.c:873 [inline]
__x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Uninit was created at:
slab_post_alloc_hook mm/slub.c:3877 [inline]
slab_alloc_node mm/slub.c:3918 [inline]
kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065
kmalloc include/linux/slab.h:628 [inline]
hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699
vfs_listxattr fs/xattr.c:493 [inline]
listxattr+0x1f3/0x6b0 fs/xattr.c:840
path_listxattr fs/xattr.c:864 [inline]
__do_sys_listxattr fs/xattr.c:876 [inline]
__se_sys_listxattr fs/xattr.c:873 [inline]
__x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
[Fix]
When allocating memory to strbuf, initialize memory to 0.
Reported-and-tested-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
fs/hfsplus/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index 9c9ff6b8c6f7..858029b1c173 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
@@ -698,7 +698,7 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size)
return err;
}
- strbuf = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
+ strbuf = kzalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
XATTR_MAC_OSX_PREFIX_LEN + 1, GFP_KERNEL);
if (!strbuf) {
res = -ENOMEM;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-05-21 5:21 ` [PATCH] hfsplus: fix " Edward Adam Davis
@ 2024-07-04 13:36 ` Dmitry Vyukov
2024-07-05 13:46 ` Edward Adam Davis
2024-07-05 21:20 ` Kees Cook
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Vyukov @ 2024-07-04 13:36 UTC (permalink / raw)
To: Edward Adam Davis
Cc: syzbot+efde959319469ff8d4d7, linux-fsdevel, linux-kernel,
syzkaller-bugs
On Tue, 21 May 2024 at 07:28, 'Edward Adam Davis' via syzkaller-bugs
<syzkaller-bugs@googlegroups.com> wrote:
>
> [syzbot reported]
> BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> sized_strscpy+0xc4/0x160
> copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> vfs_listxattr fs/xattr.c:493 [inline]
> listxattr+0x1f3/0x6b0 fs/xattr.c:840
> path_listxattr fs/xattr.c:864 [inline]
> __do_sys_listxattr fs/xattr.c:876 [inline]
> __se_sys_listxattr fs/xattr.c:873 [inline]
> __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> Uninit was created at:
> slab_post_alloc_hook mm/slub.c:3877 [inline]
> slab_alloc_node mm/slub.c:3918 [inline]
> kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065
> kmalloc include/linux/slab.h:628 [inline]
> hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699
> vfs_listxattr fs/xattr.c:493 [inline]
> listxattr+0x1f3/0x6b0 fs/xattr.c:840
> path_listxattr fs/xattr.c:864 [inline]
> __do_sys_listxattr fs/xattr.c:876 [inline]
> __se_sys_listxattr fs/xattr.c:873 [inline]
> __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [Fix]
> When allocating memory to strbuf, initialize memory to 0.
>
> Reported-and-tested-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
> fs/hfsplus/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> index 9c9ff6b8c6f7..858029b1c173 100644
> --- a/fs/hfsplus/xattr.c
> +++ b/fs/hfsplus/xattr.c
> @@ -698,7 +698,7 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size)
> return err;
> }
>
> - strbuf = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
> + strbuf = kzalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
> XATTR_MAC_OSX_PREFIX_LEN + 1, GFP_KERNEL);
> if (!strbuf) {
> res = -ENOMEM;
Hi Edward,
Was this ever merged anywhere? I still don't see it upstream.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-07-04 13:36 ` Dmitry Vyukov
@ 2024-07-05 13:46 ` Edward Adam Davis
0 siblings, 0 replies; 8+ messages in thread
From: Edward Adam Davis @ 2024-07-05 13:46 UTC (permalink / raw)
To: dvyukov
Cc: eadavis, kees, brauner, walmeida, justinstitt, linux-fsdevel,
linux-kernel, syzbot+efde959319469ff8d4d7, syzkaller-bugs
On Thu, 4 Jul 2024 15:36:37 +0200, Dmitry Vyukov wrote:
> > [syzbot reported]
> > BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> > sized_strscpy+0xc4/0x160
> > copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> > hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> > vfs_listxattr fs/xattr.c:493 [inline]
> > listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > path_listxattr fs/xattr.c:864 [inline]
> > __do_sys_listxattr fs/xattr.c:876 [inline]
> > __se_sys_listxattr fs/xattr.c:873 [inline]
> > __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> >
> > Uninit was created at:
> > slab_post_alloc_hook mm/slub.c:3877 [inline]
> > slab_alloc_node mm/slub.c:3918 [inline]
> > kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065
> > kmalloc include/linux/slab.h:628 [inline]
> > hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699
> > vfs_listxattr fs/xattr.c:493 [inline]
> > listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > path_listxattr fs/xattr.c:864 [inline]
> > __do_sys_listxattr fs/xattr.c:876 [inline]
> > __se_sys_listxattr fs/xattr.c:873 [inline]
> > __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> > [Fix]
> > When allocating memory to strbuf, initialize memory to 0.
> >
> > Reported-and-tested-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com
> > Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> > ---
> > fs/hfsplus/xattr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> > index 9c9ff6b8c6f7..858029b1c173 100644
> > --- a/fs/hfsplus/xattr.c
> > +++ b/fs/hfsplus/xattr.c
> > @@ -698,7 +698,7 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size)
> > return err;
> > }
> >
> > - strbuf = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
> > + strbuf = kzalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN +
> > XATTR_MAC_OSX_PREFIX_LEN + 1, GFP_KERNEL);
> > if (!strbuf) {
> > res = -ENOMEM;
>
> Hi Edward,
>
> Was this ever merged anywhere? I still don't see it upstream.
Yes, me too.
--
Edward
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-05-21 5:21 ` [PATCH] hfsplus: fix " Edward Adam Davis
2024-07-04 13:36 ` Dmitry Vyukov
@ 2024-07-05 21:20 ` Kees Cook
2024-07-06 7:20 ` Christian Brauner
1 sibling, 1 reply; 8+ messages in thread
From: Kees Cook @ 2024-07-05 21:20 UTC (permalink / raw)
To: syzbot+efde959319469ff8d4d7, Edward Adam Davis
Cc: Kees Cook, linux-fsdevel, linux-kernel, syzkaller-bugs
On Tue, 21 May 2024 13:21:46 +0800, Edward Adam Davis wrote:
> [syzbot reported]
> BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> sized_strscpy+0xc4/0x160
> copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> vfs_listxattr fs/xattr.c:493 [inline]
> listxattr+0x1f3/0x6b0 fs/xattr.c:840
> path_listxattr fs/xattr.c:864 [inline]
> __do_sys_listxattr fs/xattr.c:876 [inline]
> __se_sys_listxattr fs/xattr.c:873 [inline]
> __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> [...]
I've taken some security-related hfsplus stuff before, so:
Applied to for-next/hardening, thanks!
[1/1] hfsplus: fix uninit-value in copy_name
https://git.kernel.org/kees/c/974a00974829
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-07-05 21:20 ` Kees Cook
@ 2024-07-06 7:20 ` Christian Brauner
2024-07-08 6:52 ` Dmitry Vyukov
2024-07-08 19:20 ` Kees Cook
0 siblings, 2 replies; 8+ messages in thread
From: Christian Brauner @ 2024-07-06 7:20 UTC (permalink / raw)
To: Kees Cook
Cc: syzbot+efde959319469ff8d4d7, Edward Adam Davis, linux-fsdevel,
linux-kernel, syzkaller-bugs
On Fri, Jul 05, 2024 at 02:20:54PM GMT, Kees Cook wrote:
> On Tue, 21 May 2024 13:21:46 +0800, Edward Adam Davis wrote:
> > [syzbot reported]
> > BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> > sized_strscpy+0xc4/0x160
> > copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> > hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> > vfs_listxattr fs/xattr.c:493 [inline]
> > listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > path_listxattr fs/xattr.c:864 [inline]
> > __do_sys_listxattr fs/xattr.c:876 [inline]
> > __se_sys_listxattr fs/xattr.c:873 [inline]
> > __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> >
> > [...]
>
> I've taken some security-related hfsplus stuff before, so:
It's in #vfs.fixes to go out with the next vfs fixes pr.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-07-06 7:20 ` Christian Brauner
@ 2024-07-08 6:52 ` Dmitry Vyukov
2024-07-08 19:20 ` Kees Cook
1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Vyukov @ 2024-07-08 6:52 UTC (permalink / raw)
To: Christian Brauner
Cc: Kees Cook, syzbot+efde959319469ff8d4d7, Edward Adam Davis,
linux-fsdevel, linux-kernel, syzkaller-bugs
On Sat, 6 Jul 2024 at 09:20, Christian Brauner <brauner@kernel.org> wrote:
>
> On Fri, Jul 05, 2024 at 02:20:54PM GMT, Kees Cook wrote:
> > On Tue, 21 May 2024 13:21:46 +0800, Edward Adam Davis wrote:
> > > [syzbot reported]
> > > BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> > > sized_strscpy+0xc4/0x160
> > > copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> > > hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> > > vfs_listxattr fs/xattr.c:493 [inline]
> > > listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > > path_listxattr fs/xattr.c:864 [inline]
> > > __do_sys_listxattr fs/xattr.c:876 [inline]
> > > __se_sys_listxattr fs/xattr.c:873 [inline]
> > > __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > > x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > > do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > > do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> > >
> > > [...]
> >
> > I've taken some security-related hfsplus stuff before, so:
>
> It's in #vfs.fixes to go out with the next vfs fixes pr.
Oops, sorry for creating a mess.
It's just really hard to understand a random patch status.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hfsplus: fix uninit-value in copy_name
2024-07-06 7:20 ` Christian Brauner
2024-07-08 6:52 ` Dmitry Vyukov
@ 2024-07-08 19:20 ` Kees Cook
1 sibling, 0 replies; 8+ messages in thread
From: Kees Cook @ 2024-07-08 19:20 UTC (permalink / raw)
To: Christian Brauner
Cc: syzbot+efde959319469ff8d4d7, Edward Adam Davis, linux-fsdevel,
linux-kernel, syzkaller-bugs
On Sat, Jul 06, 2024 at 09:20:30AM +0200, Christian Brauner wrote:
> On Fri, Jul 05, 2024 at 02:20:54PM GMT, Kees Cook wrote:
> > On Tue, 21 May 2024 13:21:46 +0800, Edward Adam Davis wrote:
> > > [syzbot reported]
> > > BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> > > sized_strscpy+0xc4/0x160
> > > copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> > > hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> > > vfs_listxattr fs/xattr.c:493 [inline]
> > > listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > > path_listxattr fs/xattr.c:864 [inline]
> > > __do_sys_listxattr fs/xattr.c:876 [inline]
> > > __se_sys_listxattr fs/xattr.c:873 [inline]
> > > __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > > x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > > do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > > do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> > >
> > > [...]
> >
> > I've taken some security-related hfsplus stuff before, so:
>
> It's in #vfs.fixes to go out with the next vfs fixes pr.
Ah, thanks! I've dropped it from my tree now.
--
Kees Cook
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-08 19:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-18 9:21 [syzbot] [hfs?] KMSAN: uninit-value in copy_name syzbot
2024-05-21 5:21 ` [PATCH] hfsplus: fix " Edward Adam Davis
2024-07-04 13:36 ` Dmitry Vyukov
2024-07-05 13:46 ` Edward Adam Davis
2024-07-05 21:20 ` Kees Cook
2024-07-06 7:20 ` Christian Brauner
2024-07-08 6:52 ` Dmitry Vyukov
2024-07-08 19:20 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).