Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in xtSearch

Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in xtSearch

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    b6e6cc1f78c7 Merge tag 'x86_urgent_for_6.5_rc2' of git://g..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11f40fa2a80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=4a9506b1ca57ae9f
dashboard link: https://syzkaller.appspot.com/bug?extid=76a072c2f8a60280bd70
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=172c5646a80000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13360a92a80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3dfa34d80a41/disk-b6e6cc1f.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/778e016c7229/vmlinux-b6e6cc1f.xz
kernel image: https://storage.googleapis.com/syzbot-assets/c8001018a584/bzImage-b6e6cc1f.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/36bab007b655/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+76a072c2f8a60280bd70@syzkaller.appspotmail.com

================================================================================
UBSAN: array-index-out-of-bounds in fs/jfs/jfs_xtree.c:360:4
index 18 is out of range for type 'xad_t [18]'
CPU: 0 PID: 5017 Comm: syz-executor116 Not tainted 6.5.0-rc1-syzkaller-00248-gb6e6cc1f78c7 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/03/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x125/0x1b0 lib/dump_stack.c:106
 ubsan_epilogue lib/ubsan.c:217 [inline]
 __ubsan_handle_out_of_bounds+0x111/0x150 lib/ubsan.c:348
 xtSearch+0x12e2/0x1650 fs/jfs/jfs_xtree.c:360
 xtLookup+0x273/0x840 fs/jfs/jfs_xtree.c:152
 jfs_get_block+0x325/0xb20 fs/jfs/inode.c:218
 do_mpage_readpage+0x6f8/0x1ab0 fs/mpage.c:234
 mpage_readahead+0x344/0x580 fs/mpage.c:382
 read_pages+0x1d1/0xda0 mm/readahead.c:160
 page_cache_ra_unbounded+0x457/0x5e0 mm/readahead.c:269
 do_page_cache_ra mm/readahead.c:299 [inline]
 page_cache_ra_order+0x72b/0xa80 mm/readahead.c:559
 ondemand_readahead+0x540/0x1150 mm/readahead.c:681
 page_cache_sync_ra+0x174/0x1d0 mm/readahead.c:708
 page_cache_sync_readahead include/linux/pagemap.h:1213 [inline]
 filemap_get_pages+0xc05/0x1820 mm/filemap.c:2563
 filemap_splice_read+0x3d0/0x9f0 mm/filemap.c:2925
 vfs_splice_read fs/splice.c:994 [inline]
 vfs_splice_read+0x2c8/0x3b0 fs/splice.c:963
 splice_direct_to_actor+0x2a5/0xa30 fs/splice.c:1070
 do_splice_direct+0x1af/0x280 fs/splice.c:1195
 do_sendfile+0xb88/0x1390 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64 fs/read_write.c:1308 [inline]
 __x64_sys_sendfile64+0x1d6/0x220 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9707d0abc9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 81 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f97008a5168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f9707d97718 RCX: 00007f9707d0abc9
RDX: 0000000000000000 RSI: 0000000000000007 RDI: 0000000000000006
RBP: 00007f9707d97710 R08: 00007f97008a56c0 R09: 0000000000000000
R10: 0001000000201004 R11: 0000000000000246 R12: 00007f9707d9771c
R13: 000000000000006e R14: 00007ffe2c345d70 R15: 00007ffe2c345e58
 </TASK>
================================================================================


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in xtSearch

[syzbot]

syzbot suspects this issue was fixed by commit:

commit a779ed754e52d582b8c0e17959df063108bd0656
Author: Dave Kleikamp <dave.kleikamp@oracle.com>
Date:   Thu Oct 5 14:16:14 2023 +0000

    jfs: define xtree root and page independently

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16eb55af680000
start commit:   72a85e2b0a1e Merge tag 'spi-fix-v6.2-rc1' of git://git.ker..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=4e2d7bfa2d6d5a76
dashboard link: https://syzkaller.appspot.com/bug?extid=76a072c2f8a60280bd70
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15802088480000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: jfs: define xtree root and page independently

For information about bisection process see: https://goo.gl/tpsmEJ#bisection