From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>,
"'Tetsuhiro Kohada'"
<Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc: <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
<motai.hirotaka@aj.mitsubishielectric.co.jp>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
Date: Mon, 20 Apr 2020 11:51:42 +0900 [thread overview]
Message-ID: <000001d616be$9f4513b0$ddcf3b10$@samsung.com> (raw)
In-Reply-To: <b250254c-3b88-9457-652d-f96c4c15e454@gmail.com>
> On 2020/04/17 11:39, Namjae Jeon wrote:
> >> Replace "time_ms" with "time_cs" in the file directory entry
> >> structure and related functions.
> >>
> >> The unit of create_time_ms/modify_time_ms in File Directory Entry are
> >> not 'milli-second', but 'centi-second'.
> >> The exfat specification uses the term '10ms', but instead use 'cs' as
> >> in "msdos_fs.h".
> >>
> >> Signed-off-by: Tetsuhiro Kohada
> >> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> >> ---
> > I have run checkpatch.pl on your patch.
> > It give a following warning.
> >
> > WARNING: Missing Signed-off-by: line by nominal patch author
> > 'Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>'
> > total: 0 errors, 1 warnings, 127 lines checked
> >
> > Please fix it.
>
> I want to fix it, but I'm not sure what's wrong.
> The my patch has the following line:
>
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
>
> Both my real name and email address are correct.
> Can you give me some advice?
Your address in author line of this patch seems to be different with Your Signed-off-by.
From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
!=
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
What is correct one between the two?
I guess you should fix your mail address in your .gitconfig
Or manually add From: your address under subject in your patch like this.
-------------------------------------------------------------------------------
Subject: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
From: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Replace "time_ms" with "time_cs" in the file directory entry structure
and related functions.
The unit of create_time_ms/modify_time_ms in File Directory Entry are not
'milli-second', but 'centi-second'.
The exfat specification uses the term '10ms', but instead use 'cs' as in
"msdos_fs.
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
--------------------------------------------------------------------------------
>
> *** Currently I can't use office email, so I'm sending it from private
> email instead.
>
>
> --
> このEメールはアバスト アンチウイルスによりウイルススキャンされています。
> https://www.avast.com/antivirus
next prev parent reply other threads:[~2020-04-20 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200416085144epcas1p1527b8df86453c7566b1a4d5a85689e69@epcas1p1.samsung.com>
2020-04-16 8:51 ` [PATCH v3] exfat: replace 'time_ms' with 'time_cs' Tetsuhiro Kohada
2020-04-17 2:39 ` Namjae Jeon
2020-04-20 1:31 ` Tetsuhiro Kohada
2020-04-20 2:51 ` Namjae Jeon [this message]
2020-04-20 8:10 ` AW: " Schmid, Carsten
2020-04-20 22:32 ` Tetsuhiro Kohada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d616be$9f4513b0$ddcf3b10$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=Mori.Takahiro@ab.MitsubishiElectric.co.jp \
--cc=kohada.t2@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).