From: Namjae Jeon <namjae.jeon@samsung.com>
To: 'Brian Foster' <bfoster@redhat.com>
Cc: 'Dave Chinner' <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org,
'Ashish Sangwan' <a.sangwan@samsung.com>,
xfs@oss.sgi.com
Subject: RE: [PATCH v3 2/10] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate
Date: Wed, 28 May 2014 09:10:35 +0900 [thread overview]
Message-ID: <000401cf7a09$3fb514c0$bf1f3e40$@samsung.com> (raw)
In-Reply-To: <20140527205959.GA26393@bfoster.bfoster>
>
> On Tue, May 27, 2014 at 05:18:57PM +0900, Namjae Jeon wrote:
> > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
> >
> > 1) Make sure that both offset and len are block size aligned.
> > 2) Update the i_size of inode by len bytes.
> > 3) Compute the file's logical block number against offset. If the computed
> > block number is not the starting block of the extent, split the extent
> > such that the block number is the starting block of the extent.
> > 4) Shift all the extents which are lying bewteen [offset, last allocated extent]
> > towards right by len bytes. This step will make a hole of len bytes
> > at offset.
> > 5) Allocate unwritten extents for the hole created in step 4.
> >
> > Cc: Brian Foster <bfoster@redhat.com>
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > ---
>
> FYI, while I didn't notice any test failures so far, a run through some
> of the generic xfstests do produce some assert failures and whatnot. I
> noticed output from generic/013,091,127,263. I haven't looked at these
> much at all so far, I just wanted to get them on the list...
>
> Namjae, I reproduced these issues running ./check -g auto with
> CONFIG_XFS_WARN enabled for XFS (to warn on assert failures). Below is a
> quick dump of output from generic/091, as an example. That one
> reproduces consistently for me. We'll probably want to run through and
> squash this and any others before this gets merged.
Hi Brian.
I will check this problem.
Thanks for your help!
>
> Brian
>
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-28 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 8:18 [PATCH v3 2/10] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate Namjae Jeon
2014-05-27 18:40 ` Brian Foster
2014-05-27 20:59 ` Brian Foster
2014-05-28 0:10 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401cf7a09$3fb514c0$bf1f3e40$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=a.sangwan@samsung.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).