linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>
Cc: <kohada.tetsuhiro@dc.mitsubishielectric.co.jp>,
	<mori.takahiro@ab.mitsubishielectric.co.jp>,
	"'Sungjong Seo'" <sj1557.seo@samsung.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] exfat: add exfat_update_inode()
Date: Tue, 6 Oct 2020 17:23:55 +0900	[thread overview]
Message-ID: <000b01d69bba$08047320$180d5960$@samsung.com> (raw)
In-Reply-To: <20201002060505.27449-1-kohada.t2@gmail.com>

> @@ -1352,19 +1340,13 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,
>  	new_dir->i_ctime = new_dir->i_mtime = new_dir->i_atime =
>  		EXFAT_I(new_dir)->i_crtime = current_time(new_dir);
>  	exfat_truncate_atime(&new_dir->i_atime);
> -	if (IS_DIRSYNC(new_dir))
> -		exfat_sync_inode(new_dir);
> -	else
> -		mark_inode_dirty(new_dir);
> +	exfat_update_inode(new_dir);
> 
>  	i_pos = ((loff_t)EXFAT_I(old_inode)->dir.dir << 32) |
>  		(EXFAT_I(old_inode)->entry & 0xffffffff);
>  	exfat_unhash_inode(old_inode);
>  	exfat_hash_inode(old_inode, i_pos);
> -	if (IS_DIRSYNC(new_dir))
> -		exfat_sync_inode(old_inode);
> -	else
> -		mark_inode_dirty(old_inode);
> +	exfat_update_inode(old_inode);
This is checking if old_inode is IS_DIRSYNC, not new_dir.
Is there any reason ?


  reply	other threads:[~2020-10-06  8:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201002060529epcas1p2e05b4f565283969f4f2adc337f23a0d2@epcas1p2.samsung.com>
2020-10-02  6:05 ` [PATCH v3 1/2] exfat: add exfat_update_inode() Tetsuhiro Kohada
2020-10-06  8:23   ` Namjae Jeon [this message]
2020-10-07  8:13     ` Tetsuhiro Kohada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000b01d69bba$08047320$180d5960$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=kohada.t2@gmail.com \
    --cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mori.takahiro@ab.mitsubishielectric.co.jp \
    --cc=sj1557.seo@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).