* [f2fs-dev] [PATCH 2/2] f2fs: avoid unneeded lookup when xattr name length is too long
@ 2014-03-22 6:59 Chao Yu
0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2014-03-22 6:59 UTC (permalink / raw)
To: ???; +Cc: linux-f2fs-devel, linux-fsdevel, linux-kernel
In f2fs_setxattr we have limit this attribute name length, so we should also
check it in f2fs_getxattr to avoid useless lookup caused by invalid name length.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
fs/f2fs/xattr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index 0121e45..503c245 100644
--- a/fs/f2fs/xattr.c
+++ b/fs/f2fs/xattr.c
@@ -407,6 +407,8 @@ int f2fs_getxattr(struct inode *inode, int name_index, const char *name,
if (name == NULL)
return -EINVAL;
name_len = strlen(name);
+ if (name_len > F2FS_NAME_LEN)
+ return -ERANGE;
base_addr = read_all_xattrs(inode, NULL);
if (!base_addr)
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-22 7:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-22 6:59 [f2fs-dev] [PATCH 2/2] f2fs: avoid unneeded lookup when xattr name length is too long Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).