From: Fan Li <fanofcode.li@samsung.com>
To: 'Dave Chinner' <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH] fs: fix bugs for __generic_block_fiemap()
Date: Mon, 11 Jan 2016 14:41:58 +0800 [thread overview]
Message-ID: <001601d14c3b$40a1ebf0$c1e5c3d0$@samsung.com> (raw)
In-Reply-To: <20160110222153.GC10456@dastard>
> -----Original Message-----
> From: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-owner@vger.kernel.org] On Behalf Of Dave Chinner
> Sent: Monday, January 11, 2016 6:22 AM
> To: Fan Li
> Cc: linux-fsdevel@vger.kernel.org
> Subject: Re: [PATCH] fs: fix bugs for __generic_block_fiemap()
>
> On Sat, Jan 09, 2016 at 04:50:34PM +0800, Fan Li wrote:
> > Fix 3 bugs:
> > 1. If there are more than two blocks of holes after the last
> > extent of file, it would fail to add FIEMAP_EXTENT_LAST
> > to the last extent.
> > 2. len hasn't been updated correctly, if len > isize and
> > start > 0.
> > 3. If len is less than one block, it will be extended to
> > one block. If start + len exceeds the boundary of the
> > original block because of the extension, one extra block
> > will be returned.
> >
> > And simplify the codes of __generic_block_fiemap() as well.
>
> One bug fix/change per patch, please, so they can be easily reviewed.
OK, I have split it into three patches, but I'm afraid the fix for the first bug
involves a lot of modification that can't be easily divided, I hope it's enough.
Thanks.
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-01-11 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 8:50 [PATCH] fs: fix bugs for __generic_block_fiemap() Fan Li
2016-01-10 22:21 ` Dave Chinner
2016-01-11 6:41 ` Fan Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001601d14c3b$40a1ebf0$c1e5c3d0$@samsung.com' \
--to=fanofcode.li@samsung.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).