From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.samsung.com ([203.254.224.34]:41588 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758652AbcAKGmi (ORCPT ); Mon, 11 Jan 2016 01:42:38 -0500 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O0R015S5ZZ0I580@mailout4.samsung.com> for linux-fsdevel@vger.kernel.org; Mon, 11 Jan 2016 15:42:36 +0900 (KST) From: Fan Li To: 'Dave Chinner' Cc: linux-fsdevel@vger.kernel.org References: <001401d14aba$dfe6c370$9fb44a50$@samsung.com> <20160110222153.GC10456@dastard> In-reply-to: <20160110222153.GC10456@dastard> Subject: RE: [PATCH] fs: fix bugs for __generic_block_fiemap() Date: Mon, 11 Jan 2016 14:41:58 +0800 Message-id: <001601d14c3b$40a1ebf0$c1e5c3d0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Content-language: en-us Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > -----Original Message----- > From: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-owner@vger.kernel.org] On Behalf Of Dave Chinner > Sent: Monday, January 11, 2016 6:22 AM > To: Fan Li > Cc: linux-fsdevel@vger.kernel.org > Subject: Re: [PATCH] fs: fix bugs for __generic_block_fiemap() > > On Sat, Jan 09, 2016 at 04:50:34PM +0800, Fan Li wrote: > > Fix 3 bugs: > > 1. If there are more than two blocks of holes after the last > > extent of file, it would fail to add FIEMAP_EXTENT_LAST > > to the last extent. > > 2. len hasn't been updated correctly, if len > isize and > > start > 0. > > 3. If len is less than one block, it will be extended to > > one block. If start + len exceeds the boundary of the > > original block because of the extension, one extra block > > will be returned. > > > > And simplify the codes of __generic_block_fiemap() as well. > > One bug fix/change per patch, please, so they can be easily reviewed. OK, I have split it into three patches, but I'm afraid the fix for the first bug involves a lot of modification that can't be easily divided, I hope it's enough. Thanks. > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html