* [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls
@ 2015-01-02 9:42 Namjae Jeon
2015-01-06 19:10 ` Brian Foster
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2015-01-02 9:42 UTC (permalink / raw)
To: Dave Chinner, Theodore Ts'o
Cc: Brian Foster, linux-kernel, xfs, Ashish Sangwan, linux-fsdevel,
linux-ext4
This testcase(043) tries to test finsert range a single alternate block
mulitiple times and test merge code of collase range.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Cc: Brian Foster <bfoster@redhat.com>
---
tests/generic/043 | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/043.out | 7 ++++
tests/generic/group | 1 +
3 files changed, 115 insertions(+)
create mode 100644 tests/generic/043
create mode 100644 tests/generic/043.out
diff --git a/tests/generic/043 b/tests/generic/043
new file mode 100644
index 0000000..6aebc1e
--- /dev/null
+++ b/tests/generic/043
@@ -0,0 +1,107 @@
+#! /bin/bash
+# FS QA Test No. generic/043
+#
+# Test multiple fallocate insert/collapse range calls on same file.
+# For different blocksizes, Call insert range a single alternate block
+# multiple times until the file is left with 100 extents and as much
+# number of extents. And Call collapse range about the previously inserted
+# ranges to test merge code of collapse range.
+# Also check for file system consistency after completing this operation
+# for each blocksize.
+#-----------------------------------------------------------------------
+# Copyright (c) 2014 Samsung Electronics. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_scratch
+_require_xfs_io_command "fiemap"
+_require_xfs_io_command "finsert"
+_require_xfs_io_command "fcollapse"
+_do_die_on_error=y
+testfile=$SCRATCH_MNT/$seq.$$
+BLOCKS=100
+
+for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do
+
+ length=$(($BLOCKS * $BSIZE))
+ case $FSTYP in
+ xfs)
+ _scratch_mkfs -b size=$BSIZE >> $seqres.full 2>&1
+ ;;
+ ext4)
+ _scratch_mkfs -b $BSIZE >> $seqres.full 2>&1
+ ;;
+ esac
+ _scratch_mount >> $seqres.full 2>&1
+
+ # Write file
+ $XFS_IO_PROG -f -c "pwrite 0 $length" -c fsync $testfile > /dev/null
+
+
+ # Insert alternate blocks
+ for (( j=0; j < $(($BLOCKS/2)); j++ )); do
+ offset=$((($j*$BSIZE)*2))
+ $XFS_IO_PROG -c "finsert $offset $BSIZE" $testfile > /dev/null
+ done
+
+ # Check if 100 extents are present
+ $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
+
+ _check_scratch_fs
+ if [ $? -ne 0 ]; then
+ status=1
+ exit
+ fi
+
+ # Collapse alternate blocks
+ for (( j=0; j < $(($BLOCKS/2)); j++ )); do
+ offset=$((($j*$BSIZE)))
+ $XFS_IO_PROG -c "fcollapse $offset $BSIZE" $testfile > /dev/null
+ done
+
+ # Check if 1 extents are present
+ $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
+
+ _check_scratch_fs
+ if [ $? -ne 0 ]; then
+ status=1
+ exit
+ fi
+
+ umount $SCRATCH_MNT
+done
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/043.out b/tests/generic/043.out
new file mode 100644
index 0000000..fd4b804
--- /dev/null
+++ b/tests/generic/043.out
@@ -0,0 +1,7 @@
+QA output created by 043
+100
+1
+100
+1
+100
+1
diff --git a/tests/generic/group b/tests/generic/group
index c0944b3..0a10bdd 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -45,6 +45,7 @@
040 auto quick prealloc
041 auto quick prealloc
042 auto quick prealloc
+043 auto quick prealloc
053 acl repair auto quick
062 attr udf auto quick
068 other auto freeze dangerous stress
--
1.8.5.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls
2015-01-02 9:42 [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls Namjae Jeon
@ 2015-01-06 19:10 ` Brian Foster
2015-01-07 5:50 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Brian Foster @ 2015-01-06 19:10 UTC (permalink / raw)
To: Namjae Jeon
Cc: Theodore Ts'o, linux-kernel, xfs, Ashish Sangwan,
linux-fsdevel, linux-ext4
On Fri, Jan 02, 2015 at 06:42:41PM +0900, Namjae Jeon wrote:
> This testcase(043) tries to test finsert range a single alternate block
> mulitiple times and test merge code of collase range.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> Cc: Brian Foster <bfoster@redhat.com>
> ---
> tests/generic/043 | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/043.out | 7 ++++
> tests/generic/group | 1 +
> 3 files changed, 115 insertions(+)
> create mode 100644 tests/generic/043
> create mode 100644 tests/generic/043.out
>
> diff --git a/tests/generic/043 b/tests/generic/043
> new file mode 100644
> index 0000000..6aebc1e
> --- /dev/null
> +++ b/tests/generic/043
> @@ -0,0 +1,107 @@
> +#! /bin/bash
> +# FS QA Test No. generic/043
> +#
> +# Test multiple fallocate insert/collapse range calls on same file.
> +# For different blocksizes, Call insert range a single alternate block
> +# multiple times until the file is left with 100 extents and as much
> +# number of extents. And Call collapse range about the previously inserted
> +# ranges to test merge code of collapse range.
> +# Also check for file system consistency after completing this operation
> +# for each blocksize.
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2014 Samsung Electronics. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +
> +_require_scratch
> +_require_xfs_io_command "fiemap"
> +_require_xfs_io_command "finsert"
> +_require_xfs_io_command "fcollapse"
> +_do_die_on_error=y
> +testfile=$SCRATCH_MNT/$seq.$$
> +BLOCKS=100
> +
> +for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do
> +
> + length=$(($BLOCKS * $BSIZE))
> + case $FSTYP in
> + xfs)
> + _scratch_mkfs -b size=$BSIZE >> $seqres.full 2>&1
> + ;;
> + ext4)
> + _scratch_mkfs -b $BSIZE >> $seqres.full 2>&1
> + ;;
> + esac
I think we typically try to define things like blocksize in the test
configuration. The MKFS_OPTIONS env. var. can be defined with the
correct options for the associated fs being tested. That eliminates the
need to loop and for the fs-specific _scratch_mkfs calls above.
> + _scratch_mount >> $seqres.full 2>&1
> +
> + # Write file
> + $XFS_IO_PROG -f -c "pwrite 0 $length" -c fsync $testfile > /dev/null
> +
> +
> + # Insert alternate blocks
Trailing space in the above comment.
> + for (( j=0; j < $(($BLOCKS/2)); j++ )); do
> + offset=$((($j*$BSIZE)*2))
> + $XFS_IO_PROG -c "finsert $offset $BSIZE" $testfile > /dev/null
> + done
> +
> + # Check if 100 extents are present
> + $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
> +
> + _check_scratch_fs
> + if [ $? -ne 0 ]; then
> + status=1
> + exit
> + fi
> +
> + # Collapse alternate blocks
... and here as well.
> + for (( j=0; j < $(($BLOCKS/2)); j++ )); do
> + offset=$((($j*$BSIZE)))
> + $XFS_IO_PROG -c "fcollapse $offset $BSIZE" $testfile > /dev/null
> + done
> +
> + # Check if 1 extents are present
> + $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
> +
> + _check_scratch_fs
> + if [ $? -ne 0 ]; then
> + status=1
> + exit
> + fi
> +
Maybe create a copy of the original file before we run through the
insert and collapse sequence and cmp the files here as a last step?
Brian
> + umount $SCRATCH_MNT
> +done
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/043.out b/tests/generic/043.out
> new file mode 100644
> index 0000000..fd4b804
> --- /dev/null
> +++ b/tests/generic/043.out
> @@ -0,0 +1,7 @@
> +QA output created by 043
> +100
> +1
> +100
> +1
> +100
> +1
> diff --git a/tests/generic/group b/tests/generic/group
> index c0944b3..0a10bdd 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -45,6 +45,7 @@
> 040 auto quick prealloc
> 041 auto quick prealloc
> 042 auto quick prealloc
> +043 auto quick prealloc
> 053 acl repair auto quick
> 062 attr udf auto quick
> 068 other auto freeze dangerous stress
> --
> 1.8.5.5
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls
2015-01-06 19:10 ` Brian Foster
@ 2015-01-07 5:50 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2015-01-07 5:50 UTC (permalink / raw)
To: 'Brian Foster'
Cc: 'Theodore Ts'o', linux-kernel, xfs,
'Ashish Sangwan', linux-fsdevel, 'linux-ext4'
> > +
> > +for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do
> > +
> > + length=$(($BLOCKS * $BSIZE))
> > + case $FSTYP in
> > + xfs)
> > + _scratch_mkfs -b size=$BSIZE >> $seqres.full 2>&1
> > + ;;
> > + ext4)
> > + _scratch_mkfs -b $BSIZE >> $seqres.full 2>&1
> > + ;;
> > + esac
>
> I think we typically try to define things like blocksize in the test
> configuration. The MKFS_OPTIONS env. var. can be defined with the
> correct options for the associated fs being tested. That eliminates the
> need to loop and for the fs-specific _scratch_mkfs calls above.
Okay, I will change.
>
> > + _scratch_mount >> $seqres.full 2>&1
> > +
> > + # Write file
> > + $XFS_IO_PROG -f -c "pwrite 0 $length" -c fsync $testfile > /dev/null
> > +
> > +
> > + # Insert alternate blocks
>
> Trailing space in the above comment.
>
> > + for (( j=0; j < $(($BLOCKS/2)); j++ )); do
> > + offset=$((($j*$BSIZE)*2))
> > + $XFS_IO_PROG -c "finsert $offset $BSIZE" $testfile > /dev/null
> > + done
> > +
> > + # Check if 100 extents are present
> > + $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
> > +
> > + _check_scratch_fs
> > + if [ $? -ne 0 ]; then
> > + status=1
> > + exit
> > + fi
> > +
> > + # Collapse alternate blocks
>
> ... and here as well.
Okay, I wil fix both points.
>
> > + for (( j=0; j < $(($BLOCKS/2)); j++ )); do
> > + offset=$((($j*$BSIZE)))
> > + $XFS_IO_PROG -c "fcollapse $offset $BSIZE" $testfile > /dev/null
> > + done
> > +
> > + # Check if 1 extents are present
> > + $XFS_IO_PROG -c "fiemap -v" $testfile | grep "^ *[0-9]*:" |wc -l
> > +
> > + _check_scratch_fs
> > + if [ $? -ne 0 ]; then
> > + status=1
> > + exit
> > + fi
> > +
>
> Maybe create a copy of the original file before we run through the
> insert and collapse sequence and cmp the files here as a last step?
Good idea. I will add your point.
Thanks for your review!
>
> Brian
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-07 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-02 9:42 [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls Namjae Jeon
2015-01-06 19:10 ` Brian Foster
2015-01-07 5:50 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).