From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namjae Jeon Subject: RE: [PATCH v6 0/4] fat: additions to support fat_fallocate Date: Fri, 24 Oct 2014 08:52:44 +0900 Message-ID: <001c01cfef1c$70dda390$5298eab0$@samsung.com> References: <006b01cfe9fd$270488c0$750d9a40$@samsung.com> <87bnp294sn.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: 'Andrew Morton' , linux-fsdevel@vger.kernel.org To: 'OGAWA Hirofumi' Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:33243 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbaJWXwr (ORCPT ); Thu, 23 Oct 2014 19:52:47 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NDX00GTJ8ZXTCA0@mailout2.samsung.com> for linux-fsdevel@vger.kernel.org; Fri, 24 Oct 2014 08:52:45 +0900 (KST) In-reply-to: <87bnp294sn.fsf@devron.myhome.or.jp> Content-language: ko Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Namjae Jeon writes: > > > This patch set provides support for doing fallocate operation > > on FAT filesystem. > > I'm still not reviewing deeply though, basically looks like good to > me. But I'm still not testing this one at all, sorry. > > If not tested yet, we would be able to start test, e.g. stress. Hi, OGAWA. Okay, I will share stress test result(per sector size) using fsx, fsstress, etc. And will fix the review points of 2/4, 3/4 patch also. Thanks for review! > > Thanks. > > > v6: > > - Remove usage of i_disksize > > - Align all fallocate code sequence to use i_blocks as > > this is more or less can be used to denote the on-disksize. > > Also, i_blocks is common in update path of cluster allocation via. > > fat_chain_add() both from normal write path and fallocate() operation > > > > v5: > > - change all routines to make ->i_disksize aligned by cluster size. > > - merge fat_bmap2() and fat_get_block_bmap(). > > > > v4: > > - ->i_disksize is aligned by block size in fill_inode. > > - use i_disksize when computing the number of cluster for fallocate. > > - make fat_get_block_bmap to avoid race issue. > > - use __fat_write_inode() with inode_needs_sync() in evict. > > > > v3: > > - fix i_disksize and mmu_private comments(uninit/initialized) > > - remove unneeded condition in fat_bmap. > > - use mmu_private instead of fclus in fat_fallocate. > > - make function mark buffer new for block in fallocated region. > > - use flags for bmap. > > - use mmu_private instead of i_size in direct_IO. > > - use flags and remove i_mutex in bmap. > > - update vfat documentation. > > > > v2: > > - remove a stary unlock(from Dan Carpenter) > > - check ->mmu_private and ->i_disksize to truncate uninitialized data. > > > > Namjae Jeon (4): > > fat: add fat_fallocate operation > > fat: skip cluster allocation on fallocated region > > fat: permit to return phy block number by fibmap in fallocated region > > Documentation/filesystems/vfat.txt: update the limitation for fat > > fallocate > > -- > OGAWA Hirofumi