From: 张军伟 <zhangjw@ict.ac.cn>
To: <linux-fsdevel@vger.kernel.org>
Subject: A question about ext3 journal
Date: Thu, 25 Jan 2007 16:47:33 +0800 [thread overview]
Message-ID: <002701c7405d$7573ad80$0b0b0a0a@ictzhangjw> (raw)
In-Reply-To: <20070124202107.4788d802.akpm@osdl.org>
Hi all
I think there is a problem about journal in ext3.
in linux-2.6.17/include/linux/ext3_jbd.h
/* Define the number of blocks we need to account to a transaction to
* modify one block of data.
*
* We may have to touch one inode, one bitmap buffer, up to three
* indirection blocks, the group and superblock summaries, and the data
* block to complete the transaction. */
#define EXT3_SINGLEDATA_TRANS_BLOCKS 8U
The indirection blocks' modification also need their bitmap buffer and the
group summaries be modified, I think. So the block count should be 8U + 3*2;
Additionally, the journal operations in namei.c or inode.c also have the
problem like that.
Am I right? or misunderstand?
cheers, zhangjw
next prev parent reply other threads:[~2007-01-25 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 15:07 [PATCH 3/3] ufs: rellocation fix Evgeniy Dushistov
2007-01-25 4:21 ` Andrew Morton
2007-01-25 8:47 ` 张军伟 [this message]
2007-01-25 10:45 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701c7405d$7573ad80$0b0b0a0a@ictzhangjw' \
--to=zhangjw@ict.ac.cn \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).