From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super Date: Thu, 29 Jan 2015 19:24:59 +0800 Message-ID: <002a01d03bb6$530c8340$f92589c0$@samsung.com> References: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Jaegeuk Kim' , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Return-path: In-reply-to: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org> Content-language: zh-cn List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-owner@vger.kernel.org] On > Behalf Of Jaegeuk Kim > Sent: Wednesday, January 28, 2015 7:32 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super > > If wrong mount option was requested, f2fs tries to fill_super again. > But, during the next trial, f2fs has no valid mount options, since > parse_options deleted all the separators in the original string. Nice catch! But couldn't we encounter memory leak for options if we did not fail to fill super. Thanks, ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/