From: Namjae Jeon <namjae.jeon@samsung.com>
To: 'Brian Foster' <bfoster@redhat.com>,
'Namjae Jeon' <linkinjeon@gmail.com>
Cc: david@fromorbit.com, tytso@mit.edu,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
a.sangwan@samsung.com
Subject: RE: [PATCH v8 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate
Date: Fri, 16 Jan 2015 16:26:36 +0900 [thread overview]
Message-ID: <005101d0315d$c31ad6e0$495084a0$@samsung.com> (raw)
In-Reply-To: <20150115122906.GC18876@bfoster.bfoster>
> On Wed, Jan 14, 2015 at 01:05:17AM +0900, Namjae Jeon wrote:
> > From: Namjae Jeon <namjae.jeon@samsung.com>
> >
> > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
> >
> > 1) Make sure that both offset and len are block size aligned.
> > 2) Update the i_size of inode by len bytes.
> > 3) Compute the file's logical block number against offset. If the computed
> > block number is not the starting block of the extent, split the extent
> > such that the block number is the starting block of the extent.
> > 4) Shift all the extents which are lying bewteen [offset, last allocated extent]
> > towards right by len bytes. This step will make a hole of len bytes
> > at offset.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > Cc: Brian Foster<bfoster@redhat.com>
> > ---
>
> Fixes look good (I assume nothing else changed between the few nits
> called out in v7) and survives overnight fsstress and fsx testing
> without any explosions:
Yes, I am also running test for long time, If there is any issue, will share.
Thanks for your review and help :)
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
>
next prev parent reply other threads:[~2015-01-16 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 16:05 [PATCH v8 0/11] fs: Introduce FALLOC_FL_INSERT_RANGE for fallocate Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 1/11] fs: Add support " Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 2/11] xfs: " Namjae Jeon
2015-01-15 12:29 ` Brian Foster
2015-01-16 7:26 ` Namjae Jeon [this message]
2015-01-13 16:05 ` [PATCH v8 3/11] ext4: " Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 4/11] xfsprogs: xfs_io: add finsert command for insert range Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 5/11] xfstests: generic/039: Standard insert range tests Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 6/11] xfstests: generic/040: Delayed allocation insert range Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 7/11] xfstests: generic/041: Multi insert range tests Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 8/11] xfstests: generic/042: Delayed allocation multi insert Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls Namjae Jeon
2015-01-14 20:17 ` Brian Foster
2015-01-15 10:14 ` Namjae Jeon
2015-01-15 12:28 ` Brian Foster
2015-01-16 7:30 ` Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 10/11] xfstests: fsstress: Add fallocate insert range operation Namjae Jeon
2015-01-13 16:05 ` [PATCH v8 11/11] xfstests: fsx: " Namjae Jeon
2015-01-14 20:16 ` Brian Foster
2015-01-15 10:14 ` Namjae Jeon
2015-01-15 12:28 ` Brian Foster
2015-01-16 7:27 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005101d0315d$c31ad6e0$495084a0$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=a.sangwan@samsung.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).