RE: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data

[Chao Yu <chao2.yu@samsung.com>]

Hi Jeageuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Thursday, March 19, 2015 1:58 AM
> To: Chao Yu
> Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data
> 
> Hi,
> 
> On Wed, Mar 18, 2015 at 09:12:00AM +0800, Chao Yu wrote:
> > Hi Jaegeuk,
> >
> > > -----Original Message-----
> > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > > Sent: Wednesday, March 18, 2015 12:58 AM
> > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > > linux-f2fs-devel@lists.sourceforge.net
> > > Cc: Jaegeuk Kim
> > > Subject: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data
> > >
> > > This patch removes wrong f2fs_bug_on in truncate_inline_inode.
> > >
> > > When there is no space, it can happen a corner case where i_isze is over
> > > MAX_INLINE_SIZE while its inode is still inline_data.
> > >
> > > The scenario is
> > >  1. write small data into file #A.
> > >  2. fill the whole partition to 100%.
> > >  3. truncate 4096 on file #A.
> >
> > If we truncate size over MAX_INLINE_DATA, we will convert inline data in
> > f2fs_truncate rather than write_begin below. isn't it?
> 
> But, it fails to convert that due to -ENOSPC. :)

That makes sense, :)

Reviewed-by: Chao Yu <chao2.yu@samsung.com>

Thank,