From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hua Zhong" Subject: RE: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE Date: Mon, 6 Nov 2006 16:13:39 -0800 Message-ID: <015301c70201$94e88e00$0200a8c0@nuitysystems.com> References: <20061107000840.GF6012@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "'Christoph Hellwig'" , "'Linux Kernel Mailing List'" , "'linux-fsdevel'" , "'Theodore Tso'" Return-path: Received: from nz-out-0102.google.com ([64.233.162.192]:51245 "EHLO nz-out-0102.google.com") by vger.kernel.org with ESMTP id S1753857AbWKGANp (ORCPT ); Mon, 6 Nov 2006 19:13:45 -0500 Received: by nz-out-0102.google.com with SMTP id z3so961023nzf for ; Mon, 06 Nov 2006 16:13:44 -0800 (PST) To: "'Andreas Dilger'" , "'Eric Sandeen'" In-Reply-To: <20061107000840.GF6012@schatzie.adilger.int> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > Actually, rather than blindly revert to pre-patch behaviour > it would be worthwhile to determine if PAGE_SIZE isn't the > better value. In some cases people don't understand that > i_blksize is the "optimal IO size" > and instead assume it is the filesystem blocksize. I saw a > few that were e.g. 512 and that can't be very useful. Of course the name i_blksize is very clear on that. :-) > Cheers, Andreas > -- > Andreas Dilger > Principal Software Engineer > Cluster File Systems, Inc. > > - > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in the body of a message to > majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/