linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>
Cc: <kohada.tetsuhiro@dc.mitsubishielectric.co.jp>,
	<mori.takahiro@ab.mitsubishielectric.co.jp>,
	<motai.hirotaka@aj.mitsubishielectric.co.jp>,
	"'Namjae Jeon'" <namjae.jeon@samsung.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] exfat: remove useless directory scan in exfat_add_entry()
Date: Wed, 16 Sep 2020 11:22:12 +0900	[thread overview]
Message-ID: <015d01d68bd0$2fc6bb60$8f543220$@samsung.com> (raw)
In-Reply-To: <20200911044439.13842-1-kohada.t2@gmail.com>

> There is nothing in directory just created, so there is no need to scan.
> 
> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com>

Acked-by: Sungjong Seo <sj1557.seo@samsung.com>

> ---
>  fs/exfat/namei.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index
> b966b9120c9c..803748946ddb 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -530,19 +530,10 @@ static int exfat_add_entry(struct inode *inode,
> const char *path,
>  		info->size = 0;
>  		info->num_subdirs = 0;
>  	} else {
> -		int count;
> -		struct exfat_chain cdir;
> -
>  		info->attr = ATTR_SUBDIR;
>  		info->start_clu = start_clu;
>  		info->size = clu_size;
> -
> -		exfat_chain_set(&cdir, info->start_clu,
> -			EXFAT_B_TO_CLU(info->size, sbi), info->flags);
> -		count = exfat_count_dir_entries(sb, &cdir);
> -		if (count < 0)
> -			return -EIO;
> -		info->num_subdirs = count + EXFAT_MIN_SUBDIR;
> +		info->num_subdirs = EXFAT_MIN_SUBDIR;
>  	}
>  	memset(&info->crtime, 0, sizeof(info->crtime));
>  	memset(&info->mtime, 0, sizeof(info->mtime));
> --
> 2.25.1



  reply	other threads:[~2020-09-16  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200911044449epcas1p42ecc35423eebc3b62428b14529d6a592@epcas1p4.samsung.com>
2020-09-11  4:44 ` [PATCH 1/3] exfat: remove useless directory scan in exfat_add_entry() Tetsuhiro Kohada
2020-09-16  2:22   ` Sungjong Seo [this message]
2020-09-21  5:49     ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015d01d68bd0$2fc6bb60$8f543220$@samsung.com' \
    --to=sj1557.seo@samsung.com \
    --cc=kohada.t2@gmail.com \
    --cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mori.takahiro@ab.mitsubishielectric.co.jp \
    --cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
    --cc=namjae.jeon@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).