From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Chao Yu To: 'Jaegeuk Kim' Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1450832388-29118-1-git-send-email-jaegeuk@kernel.org> <1450832388-29118-4-git-send-email-jaegeuk@kernel.org> <010b01d13d66$f85f2ac0$e91d8040$@samsung.com> In-reply-to: <010b01d13d66$f85f2ac0$e91d8040$@samsung.com> Subject: RE: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed Date: Fri, 25 Dec 2015 09:38:34 +0800 Message-id: <017701d13eb5$13422640$39c672c0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Jaegeuk, > -----Original Message----- > From: Chao Yu [mailto:chao2.yu@samsung.com] > Sent: Wednesday, December 23, 2015 5:47 PM > To: 'Jaegeuk Kim' > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed > > Hi Jaegeuk, > > > -----Original Message----- > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > > Sent: Wednesday, December 23, 2015 9:00 AM > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed > > > > If user tries to update or read data, we don't need to call f2fs_balance_fs > > which triggers f2fs_gc, which increases unnecessary long latency. > > One missing case is get_data_block_dio, how about also covering it based on > following patch? > > > >From 7175efac7473e7a04285055c69edfb7432f8ca4e Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Wed, 23 Dec 2015 17:11:43 +0800 > Subject: [PATCH] f2fs: reduce covered region of sbi->cp_rwsem in > f2fs_map_blocks Title of this commit log was not merged into dev-test branch correctly, could you please reedit it? :) Thanks,