linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-fsdevel@vger.kernel.org, Christian Brauner <brauner@kernel.org>
Cc: Miklos Greczi <mgreczi@redhat.com>
Subject: [PATCH 07/14] fuse: Convert to new uid/gid option parsing helpers
Date: Thu, 27 Jun 2024 19:33:43 -0500	[thread overview]
Message-ID: <02670c04-2449-443f-bf44-68c927685a1c@redhat.com> (raw)
In-Reply-To: <8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com>

Convert to new uid/gid option parsing helpers

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
 fs/fuse/inode.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 99e44ea7d875..1ac528bcdb3c 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -740,8 +740,8 @@ static const struct fs_parameter_spec fuse_fs_parameters[] = {
 	fsparam_string	("source",		OPT_SOURCE),
 	fsparam_u32	("fd",			OPT_FD),
 	fsparam_u32oct	("rootmode",		OPT_ROOTMODE),
-	fsparam_u32	("user_id",		OPT_USER_ID),
-	fsparam_u32	("group_id",		OPT_GROUP_ID),
+	fsparam_uid	("user_id",		OPT_USER_ID),
+	fsparam_gid	("group_id",		OPT_GROUP_ID),
 	fsparam_flag	("default_permissions",	OPT_DEFAULT_PERMISSIONS),
 	fsparam_flag	("allow_other",		OPT_ALLOW_OTHER),
 	fsparam_u32	("max_read",		OPT_MAX_READ),
@@ -799,16 +799,12 @@ static int fuse_parse_param(struct fs_context *fsc, struct fs_parameter *param)
 		break;
 
 	case OPT_USER_ID:
-		ctx->user_id = make_kuid(fsc->user_ns, result.uint_32);
-		if (!uid_valid(ctx->user_id))
-			return invalfc(fsc, "Invalid user_id");
+		ctx->user_id = result.uid;
 		ctx->user_id_present = true;
 		break;
 
 	case OPT_GROUP_ID:
-		ctx->group_id = make_kgid(fsc->user_ns, result.uint_32);
-		if (!gid_valid(ctx->group_id))
-			return invalfc(fsc, "Invalid group_id");
+		ctx->group_id = result.gid;
 		ctx->group_id_present = true;
 		break;
 
-- 
2.45.2



  parent reply	other threads:[~2024-06-28  0:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  0:24 [PATCH 0/14] New uid & gid mount option parsing helpers Eric Sandeen
2024-06-28  0:26 ` [PATCH 01/14] fs_parse: add uid & gid option " Eric Sandeen
2024-06-28  9:45   ` Jan Kara
2024-06-28 12:23     ` Christian Brauner
2024-07-01  9:34       ` Jan Kara
2024-06-28 13:44     ` Eric Sandeen
2024-06-28  0:27 ` [PATCH 02/14] autofs: Convert to new uid/gid " Eric Sandeen
2024-07-01  3:05   ` Ian Kent
2024-06-28  0:29 ` [PATCH 03/14] debugfs: " Eric Sandeen
2024-06-28  0:30 ` [PATCH 04/14] efivarfs: " Eric Sandeen
2024-06-28  0:31 ` [PATCH 05/14] exfat: " Eric Sandeen
2024-06-28  0:32 ` [PATCH 06/14] ext4: " Eric Sandeen
2024-06-28  0:33 ` Eric Sandeen [this message]
2024-06-28 12:07   ` [PATCH 07/14] fuse: " Christian Brauner
2024-06-28 13:41     ` Eric Sandeen
2024-06-28  0:35 ` [PATCH 08/14] hugetlbfs: " Eric Sandeen
2024-06-28  0:36 ` [PATCH 09/14] isofs: " Eric Sandeen
2024-06-28  0:37 ` [PATCH 10/14] ntfs3: " Eric Sandeen
2024-06-28  0:38 ` [PATCH 11/14] tmpfs: " Eric Sandeen
2024-06-28  0:39 ` [PATCH 12/14] smb: client: " Eric Sandeen
2024-06-28  0:40 ` [PATCH 13/14] tracefs: " Eric Sandeen
2024-06-28 12:35   ` Steven Rostedt
2024-06-28  0:42 ` [PATCH 14/14] vboxsf: " Eric Sandeen
2024-06-28  6:43   ` Hans de Goede
2024-06-28 11:51 ` [PATCH 0/14] New uid & gid mount " Christian Brauner
2024-07-02  4:25 ` (subset) " Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02670c04-2449-443f-bf44-68c927685a1c@redhat.com \
    --to=sandeen@redhat.com \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mgreczi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).