From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0600FC433F5 for ; Sat, 8 Jan 2022 03:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbiAHD1D (ORCPT ); Fri, 7 Jan 2022 22:27:03 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:54591 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233462AbiAHD1C (ORCPT ); Fri, 7 Jan 2022 22:27:02 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id BAA473201DE2; Fri, 7 Jan 2022 22:27:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 07 Jan 2022 22:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm2; bh= Drod5sNhsivc7N2/9D6/o/MYUJj+1swCdtB1mjRfUVE=; b=H6bzfqlohtX1E02S lMgENfW6BZoWYoY4qWX6afdU+o7SZBkI5U5kYorNjlLXG4AJXKwQL2Qw4d9jo+gU f7PiJPMkGKY3P2TG/VV2qW9DxfTc6QxOBaLqt7wnR0gto22h2L0eVRFAHLvEIkHQ X+0d5AkOuuxI/4DvG9gDymUWmR5lQK+XnUWXwxEhOGF5A7oFtGKei0pBYTi8Rdje sYF70ldJJnguV09e0qNXvV1udHXoNG/mk+IfbPagVERK8ZNVNSQDLiTJ7Z0brhMv H5cMECBBQSTmHWWDNMRZJgnUmPddZk1MVQTsG4qhyjE1T00UbcTkvqv6CO/h1sTF Hgphyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Drod5sNhsivc7N2/9D6/o/MYUJj+1swCdtB1mjRfU VE=; b=C89yJ5nT3pfU2ZkVrJ4TMZnrdVI9f5BYx5qnI1Xn5jim7ppl9Wj/ygEcB ctj9FPXDmLo5V7uipjYojVy1jTy+Q9eRgC0Ho93PuQvIPbgMPntQOAxOfyP79RA5 2YBiFAvJATL3FHubwdIqcQ8TxnUmJBlY2lBq2VtcEc3kFw+CEl5DA8NVEn1RAuE3 ZtYmK/ICVmhi+gdQ5Kmv0XToPzbyenfmFvBLzr4nFS3TQxeAZQbnOIiy+K4Qw5HZ bfCS2ViZ1wLKBT+KVRSNSL04I8cdM05N5E0X2r321XUebSV4+Z/bzv1TUzUGWPQG 5lg/G2sVNN5QMed/BHHMaePYT4/Wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudegfedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthekredttderudenucfhrhhomhepkfgrnhcu mfgvnhhtuceorhgrvhgvnhesthhhvghmrgifrdhnvghtqeenucggtffrrghtthgvrhhnpe ffledvtdelheevudevhfekjeefvdekteffueejtdduveeftdevheeuveeihfelffenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrghvvghnse hthhgvmhgrfidrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Jan 2022 22:26:58 -0500 (EST) Message-ID: <02d56c068933d8084daa68dcad3bc87be764078c.camel@themaw.net> Subject: Re: [PATCH] namei: clear nd->root.mnt before O_CREAT unlazy From: Ian Kent To: Al Viro , Brian Foster Cc: linux-fsdevel@vger.kernel.org Date: Sat, 08 Jan 2022 11:26:52 +0800 In-Reply-To: References: <20220105180259.115760-1-bfoster@redhat.com> <4a13a560520e1ef522fcbb9f7dfd5e8c88d5b238.camel@themaw.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4 (3.40.4-2.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, 2022-01-07 at 17:51 +0000, Al Viro wrote: > On Fri, Jan 07, 2022 at 12:32:17PM -0500, Brian Foster wrote: > > > > Other problems here (aside of whitespace damage - was that a > > > cut'n'paste of some kind?  Looks like 8859-1 NBSP for each > > > leading space...) are > > > > Hmm.. I don't see any whitespace damage, even if I pull the patch > > back > > from the mailing list into my tree..? > > That had occured in Ian's reply, almost certainly.  Looks like > whatever > he's using for MUA (Evolution?) is misconfigured into doing > whitespace > damage - his next mail (in utf8, rather than 8859-1) had a scattering > of > U+00A0 in it...  Frankly, I'd never seen a decent GUI MUA, so I've no > real experience with that thing and no suggestions on how to fix > that. Yes, your right, I've changed that. I'll play around some more to see if I can verify things are working, mutt should be able to tell me that ... Ian > > > >         * misleading name of the new helper - it sounds like > > > "non-RCU side of complete_walk()" and that's not what it does > > > > The intent was the opposite, of course. :P I'm not sure how you > > infer > > the above from _rcu(), but I'll name the helper whatever. > > Suggestions? > > s/non-// in the above (I really had been half-asleep).  What I'm > saying is that this name invites an assumption that in RCU case > complete_walk() is equivalent to it.  Which is wrong - that's > what complete_walk() does as the first step if it needs to get > out of RCU mode.