linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Sungjong Seo'" <sj1557.seo@samsung.com>,
	"'Hyeongseok Kim'" <hyeongseok@gmail.com>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] exfat: improve performance of exfat_free_cluster when using dirsync mount option
Date: Fri, 8 Jan 2021 09:19:07 +0900	[thread overview]
Message-ID: <031e01d6e553$e0ef3e30$a2cdba90$@samsung.com> (raw)
In-Reply-To: <244001d6e4bd$a18072f0$e48158d0$@samsung.com>

> > There are stressful update of cluster allocation bitmap when using
> > dirsync mount option which is doing sync buffer on every cluster bit clearing.
> > This could result in performance degradation when deleting big size file.
> > Fix to update only when the bitmap buffer index is changed would make
> > less disk access, improving performance especially for truncate operation.
> >
> > Testing with Samsung 256GB sdcard, mounted with dirsync option (mount
> > -t exfat /dev/block/mmcblk0p1 /temp/mount -o dirsync)
> >
> > Remove 4GB file, blktrace result.
> > [Before] : 39 secs.
> > Total (blktrace):
> >  Reads Queued:      0,        0KiB	 Writes Queued:      32775,
> 16387KiB
> >  Read Dispatches:   0,        0KiB	 Write Dispatches:   32775,
> 16387KiB
> >  Reads Requeued:    0		         Writes Requeued:        0
> >  Reads Completed:   0,        0KiB	 Writes Completed:   32775,
> 16387KiB
> >  Read Merges:       0,        0KiB	 Write Merges:           0,
> 0KiB
> >  IO unplugs:        2        	     Timer unplugs:          0
> >
> > [After] : 1 sec.
> > Total (blktrace):
> >  Reads Queued:      0,        0KiB	 Writes Queued:         13,
> 6KiB
> >  Read Dispatches:   0,        0KiB	 Write Dispatches:      13,
> 6KiB
> >  Reads Requeued:    0		         Writes Requeued:        0
> >  Reads Completed:   0,        0KiB	 Writes Completed:      13,
> 6KiB
> >  Read Merges:       0,        0KiB	 Write Merges:           0,
> 0KiB
> >  IO unplugs:        1        	     Timer unplugs:          0
> >
> > Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
> 
> Looks good.
> Thanks for your work!
> 
> Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
Applied. Thanks!



      reply	other threads:[~2021-01-08  0:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210106044038epcas1p2d3488531b0a63c122f7401d4d56b03a8@epcas1p2.samsung.com>
2021-01-06  4:39 ` [PATCH] exfat: improve performance of exfat_free_cluster when using dirsync mount option Hyeongseok Kim
2021-01-07  6:23   ` Sungjong Seo
2021-01-08  0:19     ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='031e01d6e553$e0ef3e30$a2cdba90$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=hyeongseok@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).