From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Hyeongseok.Kim'" <hyeongseok@gmail.com>, <namjae.jeon@samsung.com>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH v2] exfat: Set the unused characters of FileName field to the value 0000h
Date: Tue, 9 Jun 2020 16:46:42 +0900 [thread overview]
Message-ID: <03cc01d63e32$1dec4a40$59c4dec0$@samsung.com> (raw)
In-Reply-To: <1591680644-8378-1-git-send-email-Hyeongseok@gmail.com>
> Some fsck tool complain that padding part of the FileName field is not set
> to the value 0000h. So let's maintain filesystem cleaner, as exfat's spec.
> recommendation.
>
> Signe-off-by: Hyeongseok.Kim <Hyeongseok@gmail.com>
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Looks good to me. Thanks.
> ---
> fs/exfat/dir.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index de43534..8e775bd 100644
> --- a/fs/exfat/dir.c
> +++ b/fs/exfat/dir.c
> @@ -425,10 +425,12 @@ static void exfat_init_name_entry(struct
> exfat_dentry *ep,
> ep->dentry.name.flags = 0x0;
>
> for (i = 0; i < EXFAT_FILE_NAME_LEN; i++) {
> - ep->dentry.name.unicode_0_14[i] = cpu_to_le16(*uniname);
> - if (*uniname == 0x0)
> - break;
> - uniname++;
> + if (*uniname != 0x0) {
> + ep->dentry.name.unicode_0_14[i] =
> cpu_to_le16(*uniname);
> + uniname++;
> + } else {
> + ep->dentry.name.unicode_0_14[i] = 0x0;
> + }
> }
> }
>
> --
> 2.7.4
next prev parent reply other threads:[~2020-06-09 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200609053051epcas1p2dcc80d99a10bcc83e11fda481239e64a@epcas1p2.samsung.com>
2020-06-09 5:30 ` [PATCH v2] exfat: Set the unused characters of FileName field to the value 0000h Hyeongseok.Kim
2020-06-09 7:46 ` Sungjong Seo [this message]
2020-06-10 2:59 ` Namjae Jeon
2020-06-11 0:22 ` hyeongseok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03cc01d63e32$1dec4a40$59c4dec0$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=hyeongseok@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).