From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James R. Bergsten" Subject: RE: [PATCH 5/5 v2] nvme: LightNVM support Date: Thu, 16 Apr 2015 09:01:35 -0700 Message-ID: <057301d0785e$9f8e81c0$deab8540$@thebergstens.com> References: <1429101284-19490-1-git-send-email-m@bjorling.me> <1429101284-19490-6-git-send-email-m@bjorling.me> <694D3575-E49B-45BB-8E48-7188169B75F0@paletta.io> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , =?utf-8?Q?'Matias_Bj=C3=B8rling'?= , , , , To: "'Keith Busch'" , =?utf-8?Q?'Javier_Gonz=C3=A1lez'?= Return-path: Received: from mout.perfora.net ([74.208.4.194]:59226 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbbDPQCb convert rfc822-to-8bit (ORCPT ); Thu, 16 Apr 2015 12:02:31 -0400 In-Reply-To: Content-Language: en-us Sender: linux-fsdevel-owner@vger.kernel.org List-ID: My two cents worth is that it's (always) better to put ALL the commands= into one place so that the entire set can be viewed at once and thus a= void inadvertent overloading of an opcode. Otherwise you don't know wh= at you don't know. -----Original Message----- =46rom: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On B= ehalf Of Keith Busch Sent: Thursday, April 16, 2015 8:52 AM To: Javier Gonz=C3=A1lez Cc: hch@infradead.org; Matias Bj=C3=B8rling; axboe@fb.com; linux-kernel= @vger.kernel.org; linux-nvme@lists.infradead.org; Keith Busch; linux-fs= devel@vger.kernel.org Subject: Re: [PATCH 5/5 v2] nvme: LightNVM support On Thu, 16 Apr 2015, Javier Gonz=C3=A1lez wrote: >> On 16 Apr 2015, at 16:55, Keith Busch wrote: >> >> Otherwise it looks pretty good to me, but I think it would be cleane= r=20 >> if the lightnvm stuff is not mixed in the same file with the standar= d=20 >> nvme command set. We might end up splitting nvme-core in the future=20 >> anyway for command sets and transports. > > Would you be ok with having nvme-lightnvm for LightNVM specific=20 > commands? Sounds good to me, but I don't really have a dog in this fight. :) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html