From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:4610 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdB1QkD (ORCPT ); Tue, 28 Feb 2017 11:40:03 -0500 Subject: Re: [PATCH] dax: constify second argument of dax_iomap_pmd_fault To: =?UTF-8?Q?J=c3=a9r=c3=a9my_Lefaure?= , Alexander Viro , Matthew Wilcox , Ross Zwisler References: <20170228002023.23239-1-jeremy.lefaure@lse.epita.fr> Cc: linux-fsdevel@vger.kernel.org From: Dave Jiang Message-ID: <064cb286-f65e-8941-867d-3103b485d526@intel.com> Date: Tue, 28 Feb 2017 09:38:37 -0700 MIME-Version: 1.0 In-Reply-To: <20170228002023.23239-1-jeremy.lefaure@lse.epita.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 02/27/2017 05:20 PM, Jérémy Lefaure wrote: > When CONFIG_FS_DAX_PMD is disabled, the second argument of the function > dax_iomap_pmd_fault is not a const pointer. The compiler raises a > warning about that: > fs/dax.c: In function ‘dax_iomap_fault’: > fs/dax.c:1462:35: warning: passing argument 2 of ‘dax_iomap_pmd_fault’ > discards ‘const’ qualifier from pointer target type > return dax_iomap_pmd_fault(vmf, ops); > ^~~ > fs/dax.c:1439:12: note: expected ‘struct iomap_ops *’ but argument is of > type ‘const struct iomap_ops *’ > static int dax_iomap_pmd_fault(struct vm_fault *vmf, struct iomap_ops *ops) > ^~~~~~~~~~~~~~~~~~~ > > Constifying the second argument as it is when CONFIG_FX_DAX_PMD is > enabled fixes this warning. > > Fixes: a2d581675d48("mm,fs,dax: change ->pmd_fault to ->huge_fault") > Signed-off-by: Jérémy Lefaure Thanks. Fix already submitted. http://marc.info/?l=linux-mm&m=148821429608976&w=2 > --- > fs/dax.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 5ae8b71ebadc..7436c98b92c8 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -1436,7 +1436,8 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > return result; > } > #else > -static int dax_iomap_pmd_fault(struct vm_fault *vmf, struct iomap_ops *ops) > +static int dax_iomap_pmd_fault(struct vm_fault *vmf, > + const struct iomap_ops *ops) > { > return VM_FAULT_FALLBACK; > } >