From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43302C433E1 for ; Wed, 8 Jul 2020 04:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D393206BE for ; Wed, 8 Jul 2020 04:07:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="fCztVvNu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbgGHEHP (ORCPT ); Wed, 8 Jul 2020 00:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728234AbgGHEHP (ORCPT ); Wed, 8 Jul 2020 00:07:15 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D8B5C08C5DC for ; Tue, 7 Jul 2020 21:07:14 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id s10so47333657wrw.12 for ; Tue, 07 Jul 2020 21:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DmAnW+aNGSPXA4C+WrMJa+vZ8I/2yjEhwhvCqyjrf7Y=; b=fCztVvNuDI1vxwSHFZrzUHl20rgV2FUL9YtFDf6ClChW8eytN1eZvcQPgEg9UkhzrD qTflp5G7V2JknyBoAT2rmvgi7qvLrmQPysDBRPDhcX3y7r1iXblAx3davUCG0hQe/ArX CDzlhKWrcFFyh79S3f5faVfWQayMukqk7b5RE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DmAnW+aNGSPXA4C+WrMJa+vZ8I/2yjEhwhvCqyjrf7Y=; b=Yi6ghqialHTr+6Cm3h0RVtlljf/RI2+cCFWubH5UHGLvwWrUVeIzshnxQ8Z9rmUx2T uKt7BDijZFWNrGktvB2KewtziJZOSn9dDGBXMr20Qk/qFEQvjXMXpBte64o0Yz5P+t5I c6vN+YLKD2FZXi2kXFOpxEEQR/95drqSO1wPagBcJG4OXpOuKeS85FXYizXFounuQoQ+ gWmjdYed8yEATz40sWVGWu6Pn8r87Ft5sYb8wDLhXcdc1JvelLTFIeveeGrMLtFX+9NU Re/Z2LiNfvRxdwcqKIUrpump8XyVyMex+bMNUoBh9DfZobEWc2Om1dKh/xBTIWPebhY5 ki1Q== X-Gm-Message-State: AOAM530W6gvyjJ1Kopw1sDTrV/YgGq5291qAudWqsdk9lcGl/xYf81il FXd+fMv7PoZkJbTnrFtugiwyxg== X-Google-Smtp-Source: ABdhPJyzr90jOVAoqFWvMEUHYTnBp5r5AE5rgTXyXvuhrlE1JUT/h/4/UApapPz2oWQxlhwEWPjRgg== X-Received: by 2002:a05:6000:1006:: with SMTP id a6mr53961498wrx.332.1594181233107; Tue, 07 Jul 2020 21:07:13 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id 1sm3703411wmf.21.2020.07.07.21.07.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 21:07:12 -0700 (PDT) Subject: Re: [PATCH v10 3/9] firmware: add request_partial_firmware_into_buf To: Kees Cook Cc: Luis Chamberlain , Wolfram Sang , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , Mimi Zohar , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200706232309.12010-1-scott.branden@broadcom.com> <20200706232309.12010-4-scott.branden@broadcom.com> <202007071657.55C2CFA57@keescook> From: Scott Branden Message-ID: <0681c21c-b2de-068a-76f3-965cecfbf93c@broadcom.com> Date: Tue, 7 Jul 2020 21:07:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <202007071657.55C2CFA57@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2020-07-07 4:58 p.m., Kees Cook wrote: > On Mon, Jul 06, 2020 at 04:23:03PM -0700, Scott Branden wrote: >> Add request_partial_firmware_into_buf to allow for portions >> of firmware file to be read into a buffer. Necessary where firmware >> needs to be loaded in portions from file in memory constrained systems. > Just tear out the differing "id" and just use FW_OPT_PARTIAL and I think > if Luis is happy, you're all set. > I hope so.  Also, I will need to call kernel_pread_file_from_path_initns() if FW_OPT_PARTIAL is set and kernel_read_file_from_path_initns() otherwise to avoid a swiss army-knife approach of calling a common function with multiple parameters.