linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yanko Kaneti <yaneti@declera.com>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [5.14-rc1 regression] 7fe1e79b59ba configfs: implement the .read_iter and .write_iter methods - affects targetcli restore
Date: Mon, 12 Jul 2021 17:35:16 -0700	[thread overview]
Message-ID: <070508e7-d7d1-cec7-8dda-28dca3dc2f63@acm.org> (raw)
In-Reply-To: <9e3b381a04fd7f7dfbf5e2395d127ab4ef554f99.camel@declera.com>

On 7/12/21 12:10 PM, Yanko Kaneti wrote:
> Bisected a problem that I have with targetcli restore to:
> 
> 7fe1e79b59ba configfs: implement the .read_iter and .write_iter methods
> 
> With it reads of /sys/kernel/config/target/dbroot  go on infinitely,
> returning  the config value over and over again.
> 
> e.g.
> 
> $ modprobe target_core_user
> $ head -n 2 /sys/kernel/config/target/dbroot
> /etc/target
> /etc/target
> 
> Don't know if that's a problem with the commit or the target code, but
> could perhaps be affecting other places.

The dbroot show method looks fine to me:

static ssize_t target_core_item_dbroot_show(struct config_item *item,
					    char *page)
{
	return sprintf(page, "%s\n", db_root);
}

Anyway, I can reproduce this behavior. I will take a look at this.

Bart.

  reply	other threads:[~2021-07-13  0:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 19:10 [5.14-rc1 regression] 7fe1e79b59ba configfs: implement the .read_iter and .write_iter methods - affects targetcli restore Yanko Kaneti
2021-07-13  0:35 ` Bart Van Assche [this message]
2021-07-14  6:26   ` Leon Romanovsky
2021-07-14  8:11     ` Yanko Kaneti
2021-07-14  8:30       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070508e7-d7d1-cec7-8dda-28dca3dc2f63@acm.org \
    --to=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=yaneti@declera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).