From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: ming.lei@canonical.com, mchristi@redhat.com, david@fromorbit.com,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: fix loop discard regression
Date: Thu, 4 Aug 2016 08:35:45 -0600 [thread overview]
Message-ID: <076cce77-d6ee-fc4e-8bf8-672d5c689c5e@kernel.dk> (raw)
In-Reply-To: <1470319801-20594-1-git-send-email-hch@lst.de>
On 08/04/2016 08:09 AM, Christoph Hellwig wrote:
> The first patch fixes a regression where discard request were accidentally
> marked as aio after the req_op conversion. This would have been mostly
> harmless except for the god-awful parsing of request types later in the
> actual I/O handler which turns them into a write, so the second patch
> rewrites that handler using a proper switch statement as well.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2016-08-04 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:09 fix loop discard regression Christoph Hellwig
2016-08-04 14:10 ` [PATCH 1/2] loop: don't try to use AIO for discards Christoph Hellwig
2016-08-04 14:24 ` Ming Lei
2016-08-04 14:10 ` [PATCH 2/2] loop: make do_req_filebacked more robust Christoph Hellwig
2016-08-04 14:35 ` Jens Axboe [this message]
2016-08-04 18:55 ` fix loop discard regression Ross Zwisler
2016-08-05 7:39 ` Christoph Hellwig
2016-08-05 13:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076cce77-d6ee-fc4e-8bf8-672d5c689c5e@kernel.dk \
--to=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).