From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f179.google.com ([209.85.223.179]:36154 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933918AbcHDOfr (ORCPT ); Thu, 4 Aug 2016 10:35:47 -0400 Received: by mail-io0-f179.google.com with SMTP id b62so272554959iod.3 for ; Thu, 04 Aug 2016 07:35:47 -0700 (PDT) Subject: Re: fix loop discard regression To: Christoph Hellwig References: <1470319801-20594-1-git-send-email-hch@lst.de> Cc: ming.lei@canonical.com, mchristi@redhat.com, david@fromorbit.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org From: Jens Axboe Message-ID: <076cce77-d6ee-fc4e-8bf8-672d5c689c5e@kernel.dk> Date: Thu, 4 Aug 2016 08:35:45 -0600 MIME-Version: 1.0 In-Reply-To: <1470319801-20594-1-git-send-email-hch@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/04/2016 08:09 AM, Christoph Hellwig wrote: > The first patch fixes a regression where discard request were accidentally > marked as aio after the req_op conversion. This would have been mostly > harmless except for the god-awful parsing of request types later in the > actual I/O handler which turns them into a write, so the second patch > rewrites that handler using a proper switch statement as well. Applied, thanks. -- Jens Axboe