linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, <ast@kernel.org>,
	<daniel@iogearbox.net>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>, <marcel@holtmann.org>,
	<johan.hedberg@gmail.com>, <luiz.dentz@gmail.com>,
	<dledford@redhat.com>, <jgg@ziepe.ca>, <mustafa.ismail@intel.com>,
	<shiraz.saleem@intel.com>, <leon@kernel.org>,
	<ap420073@gmail.com>, <wg@grandegger.com>,
	<woojung.huh@microchip.com>, <andrew@lunn.ch>,
	<vivien.didelot@gmail.com>, <f.fainelli@gmail.com>,
	<olteanv@gmail.com>, <george.mccollister@gmail.com>,
	<michael.chan@broadcom.com>, <jesse.brandeburg@intel.com>,
	<anthony.l.nguyen@intel.com>, <hawk@kernel.org>,
	<john.fastabend@gmail.com>, <tariqt@nvidia.com>,
	<saeedm@nvidia.com>, <ecree.xilinx@gmail.com>,
	<habetsm.xilinx@gmail.com>, <jreuter@yaina.de>,
	<dsahern@kernel.org>, <kvalo@codeaurora.org>,
	<pkshih@realtek.com>, <trond.myklebust@hammerspace.com>,
	<anna.schumaker@netapp.com>, <viro@zeniv.linux.org.uk>,
	<andrii@kernel.org>, <mcgrof@kernel.org>, <keescook@chromium.org>,
	<yzaikin@google.com>, <jiri@nvidia.com>, <wintera@linux.ibm.com>,
	<wenjia@linux.ibm.com>, <pablo@netfilter.org>,
	<kadlec@netfilter.org>, <fw@strlen.de>, <ralf@linux-mips.org>,
	<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
	<kgraul@linux.ibm.com>, <sgarzare@redhat.com>,
	<steffen.klassert@secunet.com>, <herbert@gondor.apana.org.au>,
	<arnd@arndb.de>, <linux-bluetooth@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, <linux-can@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-hams@vger.kernel.org>,
	<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	<linux-nfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<bridge@lists.linux-foundation.org>,
	<linux-decnet-user@lists.sourceforge.net>,
	<linux-s390@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
	<coreteam@netfilter.org>,
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
Date: Wed, 29 Dec 2021 13:46:14 +0200	[thread overview]
Message-ID: <081437ff-a69d-faf5-0981-389156a90668@nvidia.com> (raw)
In-Reply-To: <20211229004913.513372-1-kuba@kernel.org>

On 29/12/2021 02:49, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
> 
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
> 
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
>  - fix build in bond on ia64
>  - fix build in ip6_fib with randconfig
> 
> CC: marcel@holtmann.org
> CC: johan.hedberg@gmail.com
> CC: luiz.dentz@gmail.com
> CC: dledford@redhat.com
> CC: jgg@ziepe.ca
> CC: mustafa.ismail@intel.com
> CC: shiraz.saleem@intel.com
> CC: leon@kernel.org
> CC: ap420073@gmail.com
> CC: wg@grandegger.com
> CC: woojung.huh@microchip.com
> CC: andrew@lunn.ch
> CC: vivien.didelot@gmail.com
> CC: f.fainelli@gmail.com
> CC: olteanv@gmail.com
> CC: george.mccollister@gmail.com
> CC: michael.chan@broadcom.com
> CC: jesse.brandeburg@intel.com
> CC: anthony.l.nguyen@intel.com
> CC: ast@kernel.org
> CC: daniel@iogearbox.net
> CC: hawk@kernel.org
> CC: john.fastabend@gmail.com
> CC: tariqt@nvidia.com
> CC: saeedm@nvidia.com
> CC: ecree.xilinx@gmail.com
> CC: habetsm.xilinx@gmail.com
> CC: jreuter@yaina.de
> CC: dsahern@kernel.org
> CC: kvalo@codeaurora.org
> CC: pkshih@realtek.com
> CC: trond.myklebust@hammerspace.com
> CC: anna.schumaker@netapp.com
> CC: viro@zeniv.linux.org.uk
> CC: andrii@kernel.org
> CC: mcgrof@kernel.org
> CC: keescook@chromium.org
> CC: yzaikin@google.com
> CC: nikolay@nvidia.com
> CC: jiri@nvidia.com
> CC: wintera@linux.ibm.com
> CC: wenjia@linux.ibm.com
> CC: pablo@netfilter.org
> CC: kadlec@netfilter.org
> CC: fw@strlen.de
> CC: ralf@linux-mips.org
> CC: jhs@mojatatu.com
> CC: xiyou.wangcong@gmail.com
> CC: kgraul@linux.ibm.com
> CC: sgarzare@redhat.com
> CC: steffen.klassert@secunet.com
> CC: herbert@gondor.apana.org.au
> CC: arnd@arndb.de
> CC: linux-bluetooth@vger.kernel.org
> CC: linux-rdma@vger.kernel.org
> CC: linux-can@vger.kernel.org
> CC: intel-wired-lan@lists.osuosl.org
> CC: bpf@vger.kernel.org
> CC: linux-hams@vger.kernel.org
> CC: ath11k@lists.infradead.org
> CC: linux-wireless@vger.kernel.org
> CC: linux-nfs@vger.kernel.org
> CC: linux-fsdevel@vger.kernel.org
> CC: bridge@lists.linux-foundation.org
> CC: linux-decnet-user@lists.sourceforge.net
> CC: linux-s390@vger.kernel.org
> CC: netfilter-devel@vger.kernel.org
> CC: coreteam@netfilter.org
> CC: virtualization@lists.linux-foundation.org
> ---
[snip]
>  net/bridge/br_ioctl.c                             | 1 +
[snip
>  70 files changed, 80 insertions(+), 1 deletion(-)
> 

For the bridge:
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>



  parent reply	other threads:[~2021-12-29 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29  0:49 [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Jakub Kicinski
2021-12-29  1:33 ` Florian Fainelli
2021-12-29 17:20   ` Jakub Kicinski
2022-01-04 15:42     ` Andy Shevchenko
2021-12-29 11:46 ` Nikolay Aleksandrov [this message]
2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=081437ff-a69d-faf5-0981-389156a90668@nvidia.com \
    --to=nikolay@nvidia.com \
    --cc=andrew@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=anna.schumaker@netapp.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ap420073@gmail.com \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=bpf@vger.kernel.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=dledford@redhat.com \
    --cc=dsahern@kernel.org \
    --cc=ecree.xilinx@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=fw@strlen.de \
    --cc=george.mccollister@gmail.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=hawk@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=jhs@mojatatu.com \
    --cc=jiri@nvidia.com \
    --cc=johan.hedberg@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jreuter@yaina.de \
    --cc=kadlec@netfilter.org \
    --cc=keescook@chromium.org \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=leon@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-decnet-user@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=mcgrof@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=mkl@pengutronix.de \
    --cc=mustafa.ismail@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pablo@netfilter.org \
    --cc=pkshih@realtek.com \
    --cc=ralf@linux-mips.org \
    --cc=saeedm@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=shiraz.saleem@intel.com \
    --cc=steffen.klassert@secunet.com \
    --cc=tariqt@nvidia.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vivien.didelot@gmail.com \
    --cc=wenjia@linux.ibm.com \
    --cc=wg@grandegger.com \
    --cc=wintera@linux.ibm.com \
    --cc=woojung.huh@microchip.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).