Re: [PATCH] Ceph: allocate non-zero page to fscache in readpage()

[Sage Weil <sage@newdream.net>]

Added to the testing branch.

Thanks!

Milosz Tanski <milosz@adfin.com> wrote:
>Li, that's a good good catch.
>
>
>On Fri, Nov 8, 2013 at 9:26 PM, Li Wang <liwang@ubuntukylin.com> wrote:
>> ceph_osdc_readpages() returns number of bytes read, currently,
>> the code only allocate full-zero page into fscache, this patch
>> fixes this.
>>
>> Signed-off-by: Li Wang <liwang@ubuntukylin.com>
>> ---
>>  fs/ceph/addr.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
>> index 6df8bd4..1e561c0 100644
>> --- a/fs/ceph/addr.c
>> +++ b/fs/ceph/addr.c
>> @@ -216,7 +216,7 @@ static int readpage_nounlock(struct file *filp,
>struct page *page)
>>         }
>>         SetPageUptodate(page);
>>
>> -       if (err == 0)
>> +       if (err >= 0)
>>                 ceph_readpage_to_fscache(inode, page);
>>
>>  out:
>> --
>> 1.7.9.5
>>
>
>
>
>-- 
>Milosz Tanski
>CTO
>10 East 53rd Street, 37th floor
>New York, NY 10022
>
>p: 646-253-9055
>e: milosz@adfin.com
>--
>To unsubscribe from this list: send the line "unsubscribe ceph-devel"
>in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html