From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/6] mm: get_user_pages: consolidate error handling To: Balbir Singh CC: Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , , Andrew Morton , LKML , linux-rdma , References: <20181012060014.10242-1-jhubbard@nvidia.com> <20181012060014.10242-2-jhubbard@nvidia.com> <20181012063034.GI8537@350D> From: John Hubbard Message-ID: <090e5019-b1b9-fdc5-73a1-902164400fe2@nvidia.com> Date: Fri, 12 Oct 2018 15:45:05 -0700 MIME-Version: 1.0 In-Reply-To: <20181012063034.GI8537@350D> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On 10/11/18 11:30 PM, Balbir Singh wrote: > On Thu, Oct 11, 2018 at 11:00:09PM -0700, john.hubbard@gmail.com wrote: >> From: John Hubbard >> >> An upcoming patch requires a way to operate on each page that >> any of the get_user_pages_*() variants returns. >> >> In preparation for that, consolidate the error handling for >> __get_user_pages(). This provides a single location (the "out:" label) >> for operating on the collected set of pages that are about to be returned. >> >> As long every use of the "ret" variable is being edited, rename >> "ret" --> "err", so that its name matches its true role. >> This also gets rid of two shadowed variable declarations, as a >> tiny beneficial a side effect. >> >> Reviewed-by: Jan Kara >> Reviewed-by: Andrew Morton >> Signed-off-by: John Hubbard >> --- > > Looks good, might not be needed but > Reviewed-by: Balbir Singh > Thanks for the review, very good to have another set of eyes on this one. -- thanks, John Hubbard NVIDIA