From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'Chuck Lever III'" <chuck.lever@oracle.com>, "'stsp'" <stsp2@yandex.ru>
Cc: "'Jeff Layton'" <jlayton@kernel.org>,
<linux-kernel@vger.kernel.org>,
"'Al Viro'" <viro@zeniv.linux.org.uk>,
"'Christian Brauner'" <brauner@kernel.org>,
<linux-fsdevel@vger.kernel.org>,
"'Shuah Khan'" <shuah@kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-api@vger.kernel.org>
Subject: RE: [PATCH 2/2] selftests: add OFD lock tests
Date: Thu, 22 Jun 2023 10:34:33 -0700 [thread overview]
Message-ID: <0a2001d9a52f$cfd24450$6f76ccf0$@mindspring.com> (raw)
In-Reply-To: <187C3E49-A977-492E-99CB-97F032B24E5F@oracle.com>
> > On Jun 22, 2023, at 1:05 PM, stsp <stsp2@yandex.ru> wrote:
> >
> >
> > 22.06.2023 21:58, Chuck Lever III пишет:
> >> IMO that's not a reason not to do this properly.
> >>
> >> You should work with Jeff and the maintainer of xfstests to make it
> >> happen.
> > But its not going to be in this patch-set anyway, as its a different
> > source tree...
>
> If others agree with me, then please drop the selftests patch from this series.
> There is a considerably higher probability that the new test will be run frequently
> by CI if it's in xfstests.
>
>
> > So I should prepare it when this is merged, or?
>
> I don't have a strong preference. A good choice is to push the test before the
> kernel changes are merged.
As an aside, an additional testing option for OFD locks is the multilock test tool that is in the nfs-ganesha project. In preparation to use OFD locks in Ganesha, I added them to multilock to check them out, and that incidentally also allows testing how the NFS client and server work when OFD locks are taken on a file from an NFS mount.
Frank
next prev parent reply other threads:[~2023-06-22 18:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:22 [PATCH 0/2] v2: F_OFD_GETLK extension to read lock info Stas Sergeev
2023-06-21 15:22 ` [PATCH 1/2] fs/locks: F_UNLCK extension for F_OFD_GETLK Stas Sergeev
2023-06-21 15:22 ` [PATCH 2/2] selftests: add OFD lock tests Stas Sergeev
2023-06-22 11:48 ` Jeff Layton
2023-06-22 16:40 ` stsp
2023-06-22 16:58 ` Chuck Lever III
2023-06-22 17:05 ` stsp
2023-06-22 17:12 ` Chuck Lever III
2023-06-22 17:31 ` stsp
2023-06-22 22:15 ` Dave Chinner
2023-06-22 17:34 ` Frank Filz [this message]
2023-08-09 7:56 ` stsp
2023-06-22 16:54 ` stsp
2023-06-21 15:22 ` [PATCH] fcntl.2: document F_UNLCK F_OFD_GETLK extension Stas Sergeev
2023-06-22 12:03 ` Jeff Layton
2023-06-23 10:07 ` stsp
-- strict thread matches above, loose matches on Subject: below --
2023-06-22 16:52 [PATCH 0/2] v3: F_OFD_GETLK extension to read lock info Stas Sergeev
2023-06-22 16:52 ` [PATCH 2/2] selftests: add OFD lock tests Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0a2001d9a52f$cfd24450$6f76ccf0$@mindspring.com' \
--to=ffilzlnx@mindspring.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stsp2@yandex.ru \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).