linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'Amir Goldstein'" <amir73il@gmail.com>,
	"'Kent Overstreet'" <kent.overstreet@linux.dev>
Cc: "'Theodore Ts'o'" <tytso@mit.edu>,
	"'Donald Buczek'" <buczek@molgen.mpg.de>,
	"'Dave Chinner'" <david@fromorbit.com>,
	"'NeilBrown'" <neilb@suse.de>, <linux-bcachefs@vger.kernel.org>,
	"'Stefan Krueger'" <stefan.krueger@aei.mpg.de>,
	"'David Howells'" <dhowells@redhat.com>,
	<linux-fsdevel@vger.kernel.org>
Subject: RE: file handle in statx
Date: Tue, 12 Dec 2023 11:18:02 -0800	[thread overview]
Message-ID: <0b5d01da2d2f$ee5df9e0$cb19eda0$@mindspring.com> (raw)
In-Reply-To: <CAOQ4uxgcUQE9Ldg8rodMXJvbU9BDCC9wGED0jANGrC-OLY1HJQ@mail.gmail.com>

> On Tue, Dec 12, 2023 at 7:44 PM Kent Overstreet <kent.overstreet@linux.dev>
> wrote:
> >
> > On Tue, Dec 12, 2023 at 09:15:29AM -0800, Frank Filz wrote:
> > > > On Tue, Dec 12, 2023 at 10:10:23AM +0100, Donald Buczek wrote:
> > > > > On 12/12/23 06:53, Dave Chinner wrote:
> > > > >
> > > > > > So can someone please explain to me why we need to try to
> > > > > > re-invent a generic filehandle concept in statx when we
> > > > > > already have a have working and widely supported user API that
> > > > > > provides exactly this functionality?
> > > > >
> > > > > name_to_handle_at() is fine, but userspace could profit from
> > > > > being able to retrieve the filehandle together with the other
> > > > > metadata in a single system call.
> > > >
> > > > Can you say more?  What, specifically is the application that
> > > > would want
> > > to do
> > > > that, and is it really in such a hot path that it would be a
> > > > user-visible improveable, let aloine something that can be actually be
> measured?
> > >
> > > A user space NFS server like Ganesha could benefit from getting
> > > attributes and file handle in a single system call.
> > >
> > > Potentially it could also avoid some of the challenges of using
> > > name_to_handle_at that is a privileged operation.
> >
> > which begs the question - why is name_to_handle_at() privileged?
> >
> 
> AFAICT, it is not privileged.
> Only open_by_handle_at() is privileged.

Ah, that makes sense. I'm a consumer of these interfaces, not so much in the kernel these days.

Ganesha depends on open_by_handle_at as well, so requires privilege to do handle stuff with kernel file systems.

In any case, Ganesha could easily benefit from a savings of system calls.

What would also be handy is a read directory with attributes that gave the statx results for each entry.

Frank


  reply	other threads:[~2023-12-12 19:18 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <12f711f9-70a2-408e-8588-2839e599b668@molgen.mpg.de>
     [not found] ` <170181366042.7109.5045075782421670339@noble.neil.brown.name>
     [not found]   ` <97375d00-4bf7-4c4f-96ec-47f4078abb3d@molgen.mpg.de>
     [not found]     ` <170199821328.12910.289120389882559143@noble.neil.brown.name>
     [not found]       ` <20231208013739.frhvlisxut6hexnd@moria.home.lan>
     [not found]         ` <170200162890.12910.9667703050904306180@noble.neil.brown.name>
     [not found]           ` <20231208024919.yjmyasgc76gxjnda@moria.home.lan>
     [not found]             ` <630fcb48-1e1e-43df-8b27-a396a06c9f37@molgen.mpg.de>
     [not found]               ` <20231208200247.we3zrwmnkwy5ibbz@moria.home.lan>
     [not found]                 ` <170233460764.12910.276163802059260666@noble.neil.brown.name>
2023-12-11 23:32                   ` file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?) Kent Overstreet
2023-12-11 23:53                     ` NeilBrown
2023-12-12  0:05                       ` Kent Overstreet
2023-12-12  0:59                         ` NeilBrown
2023-12-12  1:10                           ` Kent Overstreet
2023-12-12  2:13                             ` NeilBrown
2023-12-12  2:24                               ` Kent Overstreet
2023-12-12  9:08                               ` Christian Brauner
2023-12-12  5:53                           ` Dave Chinner
2023-12-12  6:32                             ` Amir Goldstein
2023-12-12  8:56                               ` Christian Brauner
2023-12-12 15:16                                 ` Kent Overstreet
2023-12-12 15:29                                   ` Christian Brauner
2023-12-12 15:35                                     ` Kent Overstreet
2023-12-12 15:38                                       ` Miklos Szeredi
2023-12-12 15:43                                         ` Kent Overstreet
2023-12-12 15:57                                           ` Miklos Szeredi
2023-12-12 16:08                                             ` Kent Overstreet
2023-12-12 16:30                                               ` Miklos Szeredi
2023-12-12 16:41                                                 ` Kent Overstreet
2023-12-12 21:53                                                 ` NeilBrown
2023-12-13  9:41                                               ` Christian Brauner
2023-12-12 21:46                                         ` NeilBrown
2023-12-13  9:47                                           ` Christian Brauner
2023-12-13 10:04                                             ` Christian Brauner
2023-12-14 22:47                                             ` NeilBrown
2023-12-15  0:36                                               ` Kent Overstreet
2023-12-12  9:10                               ` David Howells
2023-12-12  9:23                                 ` Christian Brauner
2023-12-12  9:28                                   ` Miklos Szeredi
2023-12-12  9:35                                     ` Christian Brauner
2023-12-12  9:42                                       ` Miklos Szeredi
2023-12-12 13:47                                         ` Christian Brauner
2023-12-12 14:06                                           ` Miklos Szeredi
2023-12-12 15:24                                             ` Christian Brauner
2023-12-12 15:28                                       ` Kent Overstreet
2023-12-12  9:46                                 ` David Howells
2023-12-12  9:10                             ` file handle in statx Donald Buczek
2023-12-12 15:20                               ` Theodore Ts'o
2023-12-12 17:15                                 ` Frank Filz
2023-12-12 17:44                                   ` Kent Overstreet
2023-12-12 18:17                                     ` Amir Goldstein
2023-12-12 19:18                                       ` Frank Filz [this message]
2023-12-12 20:59                                   ` Dave Chinner
2023-12-12 21:57                                     ` NeilBrown
2023-12-12 22:23                                       ` Dave Chinner
2023-12-12 22:36                                         ` NeilBrown
2023-12-12 22:39                                         ` Kent Overstreet
2023-12-12 23:44                                           ` Dave Chinner
2023-12-13  0:00                                             ` Kent Overstreet
2023-12-13  7:37                                 ` Donald Buczek
2023-12-13 12:28                                   ` Kent Overstreet
2023-12-13 13:48                                     ` Donald Buczek
2023-12-19  7:41                                       ` Donald Buczek
2023-12-12 15:21                             ` file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?) Kent Overstreet
2023-12-12 20:48                               ` Dave Chinner
2023-12-12 21:23                                 ` Kent Overstreet
2023-12-12 22:10                                   ` Dave Chinner
2023-12-12 22:31                                     ` NeilBrown
2023-12-12 23:06                                       ` Dave Chinner
2023-12-12 23:42                                         ` Kent Overstreet
2023-12-13  0:03                                         ` NeilBrown
2023-12-12 22:00                                 ` NeilBrown
2023-12-12  7:03                           ` David Howells
2023-12-12  0:25                     ` David Howells
2023-12-11 23:40                   ` David Howells
2023-12-12 20:59                     ` Kent Overstreet
2023-12-12 22:57                       ` NeilBrown
2023-12-12 23:43                         ` Kent Overstreet
2023-12-13  0:02                           ` NeilBrown
2023-12-13  0:14                             ` Kent Overstreet
2023-12-13 22:45                             ` Andreas Dilger
2023-12-13 23:24                               ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0b5d01da2d2f$ee5df9e0$cb19eda0$@mindspring.com' \
    --to=ffilzlnx@mindspring.com \
    --cc=amir73il@gmail.com \
    --cc=buczek@molgen.mpg.de \
    --cc=david@fromorbit.com \
    --cc=dhowells@redhat.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=stefan.krueger@aei.mpg.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).