From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B349D1C172A for ; Fri, 27 Sep 2024 14:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727449108; cv=none; b=vCTME2kEc5jNU11f8WOW/e/k72pfpsiHvvsHRiXDdA1t5/OrX0rOdn+9yGg5nQftka9VZJMtinBUanCBVAXLKjm+jotIoTZrSt8QWMYw8uDIAu5nX3SRJCUy95gCxxUQ79gscC1PFw1kS6FT3gV1WAcd+/qsGd+BhzUOMdmFmJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727449108; c=relaxed/simple; bh=gz5kgzblFEgVvHMM1++lDHMe6JbnFl7PORGLYZgFors=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WuIhRgG78w/j864pZucPZTWuc8jbpC2AP9i1JLSPCB9Hz7cpHivGTYrcyRm9TCmj5m6lvvINVzpRKxkzy6CXnlBXZMKOwuiewytP5K2N5byPTjDTvUYYuPHWWHjAo5+WA2E1iXkIUHELCEudTlqrfRMjnz/d1xNNlTPkGNPms4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=dv+0+NW0; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="dv+0+NW0" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3a09c977dfbso8178515ab.2 for ; Fri, 27 Sep 2024 07:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727449106; x=1728053906; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ozhasy6P2Xb1oYh5TEGfoMTGpcm94OU26cK0RFvw/pA=; b=dv+0+NW0QULYfi81OWyhYqPWI4A44jno28aPaKySMl+wBEuWQr7ebDMlOIWzeTnKre mrOj7nF9Jz7lNfC4P5jXtW7g/wDkTjjpEYQEsbY5F1UbUZ7+5N/+7e4XWf85c8IHCslO OItWbzEr+zVXSqC5VrkEJdZBZEGfaxZ/Pkoo4J6wCJW36wUSRfXjKTSOspSwBfdhj1kk WiKBK6oKRiJCzeXORgCHrhit7trPtmDiTAoS6r02sFSPXslMaQO58MfxM+XOVLvEzd2R 48eyHuM70pcBz7ORNrVVL/d4lXwqc2Sa5CNAU5huebwTnZ3oPJrLOO6yUDuDu/wBUMcz 5bFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727449106; x=1728053906; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ozhasy6P2Xb1oYh5TEGfoMTGpcm94OU26cK0RFvw/pA=; b=Dmg9F80JH6CH6nNn4QHfVudwWdh0/Okno3po/1pRiN+bw8/FpnHhR02TtbN2QpkWf0 JD4wz2ikjaUV52FySBYzpr9LqTZjs4AkUqbYDbHG7mkxPiOwtJwz9qrq/lKrzsoUVu5u iTEg+8HcOrqIjdIbskdEarUiK5XQEKNovdW8W8xbi3EttR7cDZvHKAF51LWqUhHo9uk9 oG0v8qhDwritO1NrJUCz6Z+N6N63/dwPeiGwa8m+WjiR3FLPb2oCMzDd5nmkgE/y+3vr KkCW5wlpsalDTL1+Vufio1MfBK7YXBd8TXCn5rsAt6/8iL8249MSanWcnOZbiwMf4pRW DRsA== X-Forwarded-Encrypted: i=1; AJvYcCUHg3o6K2cDJhGZ6KHqoKzK1afmbLEUQl3u4LQwPBRXYBpOoL/A0y55IqvQfKg6i/rLLAJ1GcBvcAYG7cVH@vger.kernel.org X-Gm-Message-State: AOJu0Yw6avUw39eR+amKqrAxAC/LMmaW5PPYN/Z1V1GQdzws0j22hGk1 faw592Rc1k/MX8bFMHLu2c304XRXssqQiU2Qmr5jH6k4h0e7TK4rUo1sPetGpZ0= X-Google-Smtp-Source: AGHT+IH8vraAyss5dfiMI4UgXMfkbfey2C1HTqAO3BTHkbK/0W8GSVWuzGv0+TFXbW2pP7mY0lBEFA== X-Received: by 2002:a05:6e02:1fe7:b0:3a2:e9ff:255a with SMTP id e9e14a558f8ab-3a3451b4b6emr32273115ab.22.1727449105798; Fri, 27 Sep 2024 07:58:25 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a344d81fa4sm6237075ab.20.2024.09.27.07.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 07:58:25 -0700 (PDT) Message-ID: <0bdce668-5711-4315-ab05-1a3492cb8bf6@kernel.dk> Date: Fri, 27 Sep 2024 08:58:24 -0600 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Known and unfixed active data loss bug in MM + XFS with large folios since Dec 2021 (any kernel from 6.1 upwards) To: Sam James , Kairui Song , Greg KH Cc: stable@kernel.org, clm@meta.com, Matthew Wilcox , ct@flyingcircus.io, david@fromorbit.com, dqminh@cloudflare.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, regressions@leemhuis.info, regressions@lists.linux.dev, torvalds@linux-foundation.org References: <0a3b09db-23e8-4a06-85f8-a0d7bbc3228b@meta.com> <87plotvuo1.fsf@gentoo.org> <87y13dtaih.fsf@gentoo.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <87y13dtaih.fsf@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/27/24 8:51 AM, Sam James wrote: > Kairui Song writes: > >> On Wed, Sep 25, 2024 at 1:16?AM Sam James wrote: >>> >>> Kairui, could you send them to the stable ML to be queued if Willy is >>> fine with it? >>> >> >> Hi Sam, > > Hi Kairui, > >> >> Thanks for adding me to the discussion. >> >> Yes I'd like to, just not sure if people are still testing and >> checking the commits. >> >> And I haven't sent seperate fix just for stable fix before, so can >> anyone teach me, should I send only two patches for a minimal change, >> or send a whole series (with some minor clean up patch as dependency) >> for minimal conflicts? Or the stable team can just pick these up? > > Please see https://www.kernel.org/doc/html/v6.11/process/stable-kernel-rules.html. > > If Option 2 can't work (because of conflicts), please follow Option 3 > (https://www.kernel.org/doc/html/v6.11/process/stable-kernel-rules.html#option-3). > > Just explain the background and link to this thread in a cover letter > and mention it's your first time. Greg didn't bite me when I fumbled my > way around it :) > > (greg, please correct me if I'm talking rubbish) It needs two cherry picks, one of them won't pick cleanly. So I suggest whoever submits this to stable does: 1) Cherry pick the two commits, fixup the simple issue with one of them. I forget what it was since it's been a week and a half since I did it, but it's trivial to fixup. Don't forget to add the "commit XXX upstream" to the commit message. 2) Test that it compiles and boots and send an email to stable@vger.kernel.org with the patches attached and CC the folks in this thread, to help spot if there are mistakes. and that should be it. Worst case, we'll need a few different patches since this affects anything back to 5.19, and each currently maintained stable kernel version will need it. -- Jens Axboe