From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1290EC3A5A1 for ; Mon, 19 Aug 2019 14:41:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2C7A2082C for ; Mon, 19 Aug 2019 14:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566225660; bh=r3rHMKzGti8fbcfNxPYG44dYD1wPeB1bVCktItPFRgI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=x+aPCKuWh5cC0ITpDGGYAlC4MVCeTGBRPN+/EeUnY0lqxsgwvWh7TYWMOksfwmyP5 gjL1btF4lhk9M6t3llmu7gBfgj9UEm5aZmbL+bKH6PBqByfS7ebBafQQknkNIoScNi E+kG+0zW0Xw3k238AGeNsPHSYDSUuaf2ZCVR3gsk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbfHSOk4 (ORCPT ); Mon, 19 Aug 2019 10:40:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:40972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfHSOk4 (ORCPT ); Mon, 19 Aug 2019 10:40:56 -0400 Received: from [192.168.0.101] (unknown [180.111.132.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F3D3206C1; Mon, 19 Aug 2019 14:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566225655; bh=r3rHMKzGti8fbcfNxPYG44dYD1wPeB1bVCktItPFRgI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GWF3MfOgguDhxBe/OCmy1z9a1tpwa32uzDILjN1amLzQvxYZbjsQxjQ7ofmJu5H2z LyM3MRixhD6J100J+sFs8x1NPbdyY5eyEg3nyUON3CaY2Eq5c41E0pa/HmAy9ipg9X 6JXsjZeXOTYGETNZFKa81ZrC7fD+SzG9Uizm8XWc= Subject: Re: [PATCH 3/6] staging: erofs: add two missing erofs_workgroup_put for corrupted images To: Gao Xiang , Chao Yu , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org Cc: LKML , linux-erofs@lists.ozlabs.org, Miao Xie , weidu.du@huawei.com, Fang Wei , stable@vger.kernel.org References: <20190819080218.GA42231@138> <20190819103426.87579-1-gaoxiang25@huawei.com> <20190819103426.87579-4-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <0d2a443b-3d06-014f-aa0b-7ca261a2437f@kernel.org> Date: Mon, 19 Aug 2019 22:40:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190819103426.87579-4-gaoxiang25@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019-8-19 18:34, Gao Xiang wrote: > As reported by erofs-utils fuzzer, these error handling > path will be entered to handle corrupted images. > > Lack of erofs_workgroup_puts will cause unmounting > unsuccessfully. > > Fix these return values to EFSCORRUPTED as well. > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Cc: # 4.19+ > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,