From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79282C47082 for ; Tue, 8 Jun 2021 15:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 557A661042 for ; Tue, 8 Jun 2021 15:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232572AbhFHPxC (ORCPT ); Tue, 8 Jun 2021 11:53:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44864 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbhFHPxB (ORCPT ); Tue, 8 Jun 2021 11:53:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623167467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C7EvR7VdOAZ/iLmKH20fyJ3KSzctR8QK2Dmq7ETeypw=; b=Yt4Rp9RCf/KYkk6eMePIAyrgF3n+ZJ7LDBJSQgRnEABfpmLDLiIHUJGMmGGXvL9fhXIyzZ wdIjaN7tLeCJB65IoOl205RUT6E123aDS0RTCGTT5Wcj/uoqQu+yiSIfPZqwb+PJ27MNNS 9RMAOfIp1NbtRkSTyqNySIMtyqtUd5g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-RTUj-QfmP0WUQaBqYpBkIg-1; Tue, 08 Jun 2021 11:51:06 -0400 X-MC-Unique: RTUj-QfmP0WUQaBqYpBkIg-1 Received: by mail-wr1-f71.google.com with SMTP id e9-20020a5d6d090000b0290119e91be97dso1382950wrq.1 for ; Tue, 08 Jun 2021 08:51:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=C7EvR7VdOAZ/iLmKH20fyJ3KSzctR8QK2Dmq7ETeypw=; b=UyBDO20fj5DwpBi+bM0eVTqh9tzeOJw27R2FpduFC3ZCFaPnLX6KvCrqQoUyHRZzYM 29faVIIQqnYTB+kbCA182N+Gq8PUzVMe0kCuclEbi5gSjaadMIrXtvnN6AAb6LpTqJyt 83tTaBrFNV5ZXLXd+b0zhCdf/x0zG7LHQZgIsXLquqHe1w2EVubdZZYsE+HI3+xSfkeI EDHUiABOS8F+YBx0IDwAQDhBkSZluvPSSLwHl9O3ZSKx0dcJtcWj0NHqptq9nHg8dYC9 U8ky1bqHh7pVrEwYWwJlFztYkKXJYNKLdCOpuHEN3ahqe7WuljPjEkyJpsWztf6V9xqW 09hg== X-Gm-Message-State: AOAM533QwNKXYQ15rTzVEaR3ZiEBI3MjhqOMgIybsIE7w+XB22rMznJb lAjAwt20rFYamxDwJFts3B8LQ0LfEMn5dPyFymNQ8fGCGmf8Ea3uon6h9aU2DWae6706cf5s9FC kkfRewvwFrpe4+eifxMsu1i/AiA== X-Received: by 2002:a1c:a917:: with SMTP id s23mr18629728wme.55.1623167464982; Tue, 08 Jun 2021 08:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWwxLZ+NJIT7rS1RBKo6fZIJ6pPJ5Jyz5Cfr4Q7NDJ2Qxk2hRHkprTl0V4yJJcD7Y+ypyeOg== X-Received: by 2002:a1c:a917:: with SMTP id s23mr18629719wme.55.1623167464880; Tue, 08 Jun 2021 08:51:04 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id s62sm3589591wms.13.2021.06.08.08.51.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 08:51:04 -0700 (PDT) Subject: Re: [PATCH v2 6/7] fuse: Switch to fc_mount() for submounts To: Greg Kurz , Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, Vivek Goyal References: <20210604161156.408496-1-groug@kaod.org> <20210604161156.408496-7-groug@kaod.org> From: Max Reitz Message-ID: <0d3b4dfb-2474-2200-80d1-39dcbf8f626e@redhat.com> Date: Tue, 8 Jun 2021 17:51:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210604161156.408496-7-groug@kaod.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 04.06.21 18:11, Greg Kurz wrote: > fc_mount() already handles the vfs_get_tree(), sb->s_umount > unlocking and vfs_create_mount() sequence. Using it greatly > simplifies fuse_dentry_automount(). > > Signed-off-by: Greg Kurz > --- > fs/fuse/dir.c | 26 +++++--------------------- > 1 file changed, 5 insertions(+), 21 deletions(-) > > diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c > index b88e5785a3dd..fc9eddf7f9b2 100644 > --- a/fs/fuse/dir.c > +++ b/fs/fuse/dir.c > @@ -311,38 +311,22 @@ static struct vfsmount *fuse_dentry_automount(struct path *path) > struct fs_context *fsc; > struct vfsmount *mnt; > struct fuse_inode *mp_fi = get_fuse_inode(d_inode(path->dentry)); > - int err; > > fsc = fs_context_for_submount(path->mnt->mnt_sb->s_type, path->dentry); > - if (IS_ERR(fsc)) { > - err = PTR_ERR(fsc); > - goto out; > - } > + if (IS_ERR(fsc)) > + return (struct vfsmount *) fsc; I think ERR_CAST(fsc) would be nicer. Apart from that: Reviewed-by: Max Reitz