From: "Takashi Sato" <sho@tnes.nec.co.jp>
To: "Dave Kleikamp" <shaggy@linux.vnet.ibm.com>,
"Jeff Garzik" <jeff@garzik.org>
Cc: <linux-ext4@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH 0/3] Extent base online defrag
Date: Fri, 17 Nov 2006 21:39:50 +0900 [thread overview]
Message-ID: <0e7101c70a45$7c28d360$4168010a@bsd.tnes.nec.co.jp> (raw)
In-Reply-To: 1163081503.10671.9.camel@kleikamp.austin.ibm.com
Hi,
>> > - Specify the target area in a file using the following structure:
>> > struct ext3_ext_defrag_data {
>> > loff_t start_offset; /* start offset to defrag in bytes */
>> > loff_t defrag_size; /* size of defrag in bytes */
>> > }
>> > It uses loff_t so that the size of the structure is identical on
>> > both 32 bits and 64 bits architecture.
>> > Block allocation, including searching for the free contiguous
>> > blocks, is implemented in kernel.
>>
>> NAK the ioctl approach.
>
> I agree it shouldn't go into mainline this way, but while the details of
> the proper interface are debated, this implementation at least allows
> the core function to be tested & reviewed.
>
>> People who like ioctls are just holdovers from non-Linux OS's.
Thank you for your comments.
My patches are at the experimental phase and the ioctl approach is
the provisional solution.
But I intend to continue this work with ioctl approach, if there are no
actual problems.
Cheers, Takashi
next prev parent reply other threads:[~2006-11-17 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 11:09 [RFC][PATCH 0/3] Extent base online defrag sho
2006-11-09 12:46 ` Jeff Garzik
2006-11-09 14:11 ` Dave Kleikamp
2006-11-17 12:39 ` Takashi Sato [this message]
2006-11-29 10:27 ` Girish Shilamkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0e7101c70a45$7c28d360$4168010a@bsd.tnes.nec.co.jp' \
--to=sho@tnes.nec.co.jp \
--cc=jeff@garzik.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).