From: Jens Axboe <axboe@kernel.dk>
To: chris.chiu@canonical.com, viro@zeniv.linux.org.uk, hch@lst.de
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: clear GD_NEED_PART_SCAN later in bdev_disk_changed
Date: Tue, 23 Mar 2021 09:58:54 -0600 [thread overview]
Message-ID: <0ec65a30-741d-9f22-e90b-1f72f68b4346@kernel.dk> (raw)
In-Reply-To: <20210323085219.24428-1-chris.chiu@canonical.com>
On 3/23/21 2:52 AM, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
>
> The GD_NEED_PART_SCAN is set by bdev_check_media_change to initiate
> a partition scan while removing a block device. It should be cleared
> after blk_drop_paritions because blk_drop_paritions could return
> -EBUSY and then the consequence __blkdev_get has no chance to do
> delete_partition if GD_NEED_PART_SCAN already cleared.
>
> It causes some problems on some card readers. Ex. Realtek card
> reader 0bda:0328 and 0bda:0158. The device node of the partition
> will not disappear after the memory card removed. Thus the user
> applications can not update the device mapping correctly.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-03-23 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 8:52 [PATCH] block: clear GD_NEED_PART_SCAN later in bdev_disk_changed chris.chiu
2021-03-23 15:51 ` Christoph Hellwig
2021-03-23 15:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec65a30-741d-9f22-e90b-1f72f68b4346@kernel.dk \
--to=axboe@kernel.dk \
--cc=chris.chiu@canonical.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).