From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. R. Okajima" Subject: Re: vfs-scale, nd->inode after __do_follow_link() Date: Fri, 14 Jan 2011 14:38:31 +0900 Message-ID: <10161.1294983511@jrobl> References: <7352.1294971049@jrobl> <20110114052813.GZ19804@ZenIV.linux.org.uk> Cc: Nick Piggin , linux-fsdevel , linux-kernel@vger.kernel.org To: Al Viro Return-path: Received: from mtoichi12.ns.itscom.net ([219.110.2.182]:36121 "EHLO mtoichi12.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941Ab1ANFif (ORCPT ); Fri, 14 Jan 2011 00:38:35 -0500 In-Reply-To: <20110114052813.GZ19804@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro: > BTW, "i" as a name for local struct inode * is -><- that close to being a > shootable offense. Please, rename to e.g. struct inode *link (and it's > struct inode, not struct dentry). I will do so when the patch will be merged. I meant the code snippet is just showing what I thought. I didn't mean it should be merged. J. R. Okajima