From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. R. Okajima" Subject: Re: vfs-scale, nd->inode after __do_follow_link() Date: Fri, 14 Jan 2011 14:40:11 +0900 Message-ID: <10175.1294983611@jrobl> References: <7352.1294971049@jrobl> <20110114052813.GZ19804@ZenIV.linux.org.uk> <10161.1294983511@jrobl> To: Al Viro , Nick Piggin , linux-fsdevel , linux-kernel@vger.kernel.org Return-path: Received: from mtoichi14.ns.itscom.net ([219.110.2.184]:55146 "EHLO mtoichi14.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928Ab1ANFkP (ORCPT ); Fri, 14 Jan 2011 00:40:15 -0500 In-Reply-To: <10161.1294983511@jrobl> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: "J. R. Okajima": > Al Viro: > > BTW, "i" as a name for local struct inode * is -><- that close to being a > > shootable offense. Please, rename to e.g. struct inode *link (and it's > > struct inode, not struct dentry). > > I will do so when the patch will be merged. > I meant the code snippet is just showing what I thought. I didn't mean > it should be merged. Forgot to write. I noticed about the "struct dentry" too and it was fixed in my second code. J. R. Okajima