From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 17/17] BLOCK: Make it possible to disable the block layer [try #2] Date: Fri, 25 Aug 2006 19:46:23 +0100 Message-ID: <10409.1156531583@warthog.cambridge.redhat.com> References: <10117.1156522985@warthog.cambridge.redhat.com> <20060825142753.GK10659@infradead.org> <20060824213252.21323.18226.stgit@warthog.cambridge.redhat.com> <20060824213334.21323.76323.stgit@warthog.cambridge.redhat.com> Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:48603 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S964917AbWHYSq2 (ORCPT ); Fri, 25 Aug 2006 14:46:28 -0400 In-Reply-To: <10117.1156522985@warthog.cambridge.redhat.com> To: David Howells Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org David Howells wrote: > Christoph Hellwig wrote: > > > Can you put this two into a single ifdef block? > > I suppose it could make sense to move the two disk random source functions > together. I don't think I should. drivers/char/random.c seems to be carefully laid out with similar functions grouped together under grouping banners. David