From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Dyson Subject: Re: [PATCH] Add lib/parser.c kernel-doc Date: Sun, 16 Nov 2003 17:21:02 -0500 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <1069021262.19499.55.camel@thalience> References: <1068970562.19499.11.camel@thalience> <20031116160958.GW30485@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: To: Matthew Wilcox In-Reply-To: <20031116160958.GW30485@parcelfarce.linux.theplanet.co.uk> List-Id: linux-fsdevel.vger.kernel.org On Sun, 2003-11-16 at 11:09, Matthew Wilcox wrote: > > -int match_int(substring_t *, int *result); > > +int match_int(substring_t *s, int *result); > > What value does this "s" add? "result" is clearly useful documentation, > but "s" says "There is no good name for this variable" True, but that is what it is named in the function definition. I'll try to think of a good name for these, but I guess a documentation patch is not the place for that (since I'd want to change it in both declaration and definition). Your other comments are well-taken as well. -- Will Dyson "Back off man, I'm a scientist!" -Dr. Peter Venkman