From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BEFC433FF for ; Wed, 14 Aug 2019 09:26:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18D30204EC for ; Wed, 14 Aug 2019 09:26:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbfHNJ0C (ORCPT ); Wed, 14 Aug 2019 05:26:02 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:38570 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725888AbfHNJ0C (ORCPT ); Wed, 14 Aug 2019 05:26:02 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3EC4DE55934583B028EE; Wed, 14 Aug 2019 17:25:55 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 14 Aug 2019 17:25:48 +0800 Subject: Re: [PATCH RESEND 2/2] staging: erofs: differentiate unsupported on-disk format To: Gao Xiang , Pavel Machek , "Greg Kroah-Hartman" , , CC: LKML , , "Chao Yu" , Miao Xie , , Fang Wei References: <20190814042525.4925-2-gaoxiang25@huawei.com> <20190814043208.15591-1-gaoxiang25@huawei.com> <20190814043208.15591-2-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <108ee2f9-75dd-b8ab-8da7-b81c17bafbf6@huawei.com> Date: Wed, 14 Aug 2019 17:25:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190814043208.15591-2-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019/8/14 12:32, Gao Xiang wrote: > For some specific fields, use ENOTSUPP instead of EIO > for values which look sane but aren't supported right now. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu > + return -ENOTSUPP; A little bit confused about when we need to use ENOTSUPP or EOPNOTSUPP, I checked several manual of syscall, it looks EOPNOTSUPP is widely used. Thanks,