* PATCH [0/7] Fix posix locking code
@ 2004-08-14 19:28 Trond Myklebust
0 siblings, 0 replies; only message in thread
From: Trond Myklebust @ 2004-08-14 19:28 UTC (permalink / raw)
To: Linux Filesystem Development, linux-kernel, Linus Torvalds,
Andrew Morton
The following patches fix up a number of inconsistencies within
the current VFS locking code.
The main problems addressed are
- Inconsistent definition of what the lock owner means.
Currently, the VFS code is sometimes using current->files,
sometimes current->tgid, and sometimes a combination of both.
It turns out that CLONE_FILES more or less forces us to use
current->files as the basis for the lock owner (or bad things
will happen) so we must drop the checks for current->tgid.
- Design worries: separate out callbacks used by lock managers,
such as lockd, and those used by filesystems.
- posix_lock_file() is called by the VFS *AFTER* the filesystem
has been notified. However because it uses no locking, and
may even sleep, there are serious race issues.
By moving the posix_lock_file() call into the filesystem
callback, the filesystem may implement its own locking scheme
to avoid trouble.
Cheers,
Trond
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-08-14 19:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-14 19:28 PATCH [0/7] Fix posix locking code Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).