From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: Andreas Gruenbacher <agruen@suse.de>,
linux-fsdevel@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Alex Tomas <alex@clusterfs.com>,
Andrew Tridgell <tridge@samba.org>
Subject: Re: [RFC] Ext3 nanosecond timestamps in big inodes
Date: Mon, 17 Jan 2005 09:49:12 +0000 [thread overview]
Message-ID: <1105955352.22856.5.camel@imp.csi.cam.ac.uk> (raw)
In-Reply-To: <20050116054604.GI22715@schnapps.adilger.int>
On Sat, 2005-01-15 at 22:46 -0700, Andreas Dilger wrote:
> On Jan 14, 2005 22:16 +0100, Andreas Gruenbacher wrote:
> > +static inline struct timespec ext3_current_time(struct inode *inode)
> > +{
> > + return (inode->i_sb->s_time_gran == 1) ?
> > + CURRENT_TIME : CURRENT_TIME_SEC;
> > +}
>
> If "s_time_gran" (I haven't seen this before but it doesn't appear to
> be a part of your patch) had some useful meaning we could use it to e.g.
> shift the nsec part of the timestamps as Andy requested so as not to make
> the timestamps change too often.
sb->s_time_gran is the granularity used for the time in each fs in
nanoseconds. So, for example in NTFS it is set to 100 as NTFS stores
time as 100ns intervals. This means the kernel time can be rounded
appropriately when the fs inode times are being updated. Without this
you can see inode time jumping backwards in time if the inode is thrown
out of memory and then read in again and in the process it had some of
the time bits truncated...
See the original post of the patch from Andi Kleen for details:
http://marc.theaimsgroup.com/?l=linux-kernel&m=110134111125012&w=2
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
prev parent reply other threads:[~2005-01-17 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 21:16 [RFC] Ext3 nanosecond timestamps in big inodes Andreas Gruenbacher
2005-01-16 5:46 ` Andreas Dilger
2005-01-17 9:49 ` Anton Altaparmakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105955352.22856.5.camel@imp.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=adilger@clusterfs.com \
--cc=agruen@suse.de \
--cc=alex@clusterfs.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tridge@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).