From: "Stephen C. Tweedie" <sct@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
linux-fsdevel@vger.kernel.org,
"ext2-devel@lists.sourceforge.net"
<ext2-devel@lists.sourceforge.net>,
Stephen Tweedie <sct@redhat.com>
Subject: Re: journal start/stop in ext3_writeback_writepage()
Date: Thu, 10 Feb 2005 23:12:51 +0000 [thread overview]
Message-ID: <1108077171.5708.17.camel@sisko.sctweedie.blueyonder.co.uk> (raw)
In-Reply-To: <20050210122124.429e4491.akpm@osdl.org>
Hi,
On Thu, 2005-02-10 at 20:21, Andrew Morton wrote:
> > But I still don't understand why this can't happen
> > thro original code ..
> > what am i missing ?
>
> presumably there are never any dirty pages or inodes when we run
> journal_destroy().
I assume so, yes. If there is no a_ops->writepages(), then we default
to generic_writepages() which is a noop if there are no dirty pages. If
your new ext3-specific writepages code tries to do a journal_start() in
that case, then yes, it is likely to blow up spectacularly during
journal_destroy!
--Stephen
next prev parent reply other threads:[~2005-02-10 23:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 16:18 journal start/stop in ext3_writeback_writepage() Badari Pulavarty
2005-02-09 16:37 ` Stephen C. Tweedie
2005-02-09 18:38 ` Badari Pulavarty
2005-02-09 23:24 ` Stephen C. Tweedie
2005-02-10 17:39 ` Badari Pulavarty
2005-02-10 19:07 ` Sonny Rao
2005-02-10 19:17 ` Badari Pulavarty
2005-02-10 20:21 ` Andrew Morton
2005-02-10 23:12 ` Stephen C. Tweedie [this message]
2005-02-11 0:22 ` [Ext2-devel] " Badari Pulavarty
2005-02-11 0:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108077171.5708.17.camel@sisko.sctweedie.blueyonder.co.uk \
--to=sct@redhat.com \
--cc=akpm@osdl.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).