From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stephen C. Tweedie" Subject: Re: journal start/stop in ext3_writeback_writepage() Date: Thu, 10 Feb 2005 23:12:51 +0000 Message-ID: <1108077171.5708.17.camel@sisko.sctweedie.blueyonder.co.uk> References: <1107965901.20053.61.camel@dyn318077bld.beaverton.ibm.com> <1107967040.1949.59.camel@sisko.sctweedie.blueyonder.co.uk> <1108057145.20053.1139.camel@dyn318077bld.beaverton.ibm.com> <1108063038.20053.1156.camel@dyn318077bld.beaverton.ibm.com> <20050210122124.429e4491.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Badari Pulavarty , linux-fsdevel@vger.kernel.org, "ext2-devel@lists.sourceforge.net" , Stephen Tweedie Received: from mx1.redhat.com ([66.187.233.31]:24192 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261889AbVBJXNO (ORCPT ); Thu, 10 Feb 2005 18:13:14 -0500 To: Andrew Morton In-Reply-To: <20050210122124.429e4491.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, On Thu, 2005-02-10 at 20:21, Andrew Morton wrote: > > But I still don't understand why this can't happen > > thro original code .. > > what am i missing ? > > presumably there are never any dirty pages or inodes when we run > journal_destroy(). I assume so, yes. If there is no a_ops->writepages(), then we default to generic_writepages() which is a noop if there are no dirty pages. If your new ext3-specific writepages code tries to do a journal_start() in that case, then yes, it is likely to blow up spectacularly during journal_destroy! --Stephen