From mboxrd@z Thu Jan 1 00:00:00 1970 From: Badari Pulavarty Subject: Re: Bufferheads & page-cache reference Date: 15 Feb 2005 10:15:43 -0800 Message-ID: <1108491343.20053.1472.camel@dyn318077bld.beaverton.ibm.com> References: <1108409415.20053.1278.camel@dyn318077bld.beaverton.ibm.com> <20050214134058.1402cfed.akpm@osdl.org> <1108430825.20053.1363.camel@dyn318077bld.beaverton.ibm.com> <20050214190556.07c4a0c9.akpm@osdl.org> <1108485967.20053.1438.camel@dyn318077bld.beaverton.ibm.com> <20050215095443.3e646401.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel Received: from e33.co.us.ibm.com ([32.97.110.131]:33197 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S261801AbVBOSPC (ORCPT ); Tue, 15 Feb 2005 13:15:02 -0500 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j1FIEx0D363224 for ; Tue, 15 Feb 2005 13:14:59 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay05.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j1FIEvZo255176 for ; Tue, 15 Feb 2005 11:14:57 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j1FIEu9N015152 for ; Tue, 15 Feb 2005 11:14:56 -0700 To: Andrew Morton In-Reply-To: <20050215095443.3e646401.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2005-02-15 at 09:54, Andrew Morton wrote: > Badari Pulavarty wrote: > > > > Yep. nobh_prepare_write() doesn't add any bufferheads. But > > we call block_write_full_page() even for "nobh" case, which > > does create bufferheads, attaches to the page and operates > > on them.. > > hmm, yeah, OK, we'll attach bh's in that case. It's a rare case though - Thanks. I just wanted to make sure I am not confused. > when a dirty page falls off the end of the LRU. There's no particular > reason why we cannot have a real mpage_writepage() which doesn't use bh's > and employ that. > > I coulda sworn we used to have one. Okay, I will cook it up. Thanks, Badari