From: Greg Banks <gnb@melbourne.sgi.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Neil Brown <neilb@cse.unsw.edu.au>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>
Subject: Re: O_NONBLOCK for regular files
Date: Wed, 13 Apr 2005 16:03:44 +1000 [thread overview]
Message-ID: <1113372223.1956.628.camel@hole.melbourne.sgi.com> (raw)
In-Reply-To: <1113371790.9903.3.camel@lade.trondhjem.org>
On Wed, 2005-04-13 at 15:56, Trond Myklebust wrote:
> on den 13.04.2005 Klokka 10:45 (+1000) skreiv Greg Banks:
>
> > There's now a patch to actually do it, see
> >
> > http://marc.theaimsgroup.com/?l=linux-nfs&m=111087383132762&w=2
> >
> > Does anyone want to give a firm yea or nea to this approach? I'd
> > really like to get this patch moving in the pipeline.
>
> Nay...
>
> if (rqstp->rq_vers == 3)
>
> is BAD!
>
> We're already busy with rq_vers == 4 (which has the same issues). This
> sort of condition needs to be handled in a more version-independent
> manner.
Yes, Neil already made this point. I have a new version of the patch
which does
if (rqstp->rq_vers >= 3)
which I'll resend if there are no other issues. I assume that'll
be good enough.
Any other issues?
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2005-04-13 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 9:24 O_NONBLOCK for regular files Greg Banks
2005-04-13 0:45 ` Greg Banks
2005-04-13 5:56 ` Trond Myklebust
2005-04-13 6:03 ` Greg Banks [this message]
2005-04-13 6:31 ` Trond Myklebust
2005-04-13 7:06 ` Greg Banks
-- strict thread matches above, loose matches on Subject: below --
2004-03-18 8:36 Christoph Hellwig
2004-03-18 8:42 ` viro
2004-03-18 8:45 ` Christoph Hellwig
2004-03-18 10:48 ` Stephen Rothwell
2004-03-18 12:05 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113372223.1956.628.camel@hole.melbourne.sgi.com \
--to=gnb@melbourne.sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).