From: "Artem B. Bityuckiy" <dedekind@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, dwmw2@infradead.org,
linux-fsdevel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between
Date: Thu, 28 Apr 2005 11:32:08 +0400 [thread overview]
Message-ID: <1114673528.3483.2.camel@sauron.oktetlabs.ru> (raw)
In-Reply-To: <E1DQqZu-0002Rf-00@dorka.pomaz.szeredi.hu>
> Why do you need to move it from prune_icache() to dispose_list()?
> For the hash list it's the right thing, but for sb_list it's not
> needed, is it?
Yes, it is not needed but harmless. I did it only because i_hash &
i_sb_list insertions/deletions always come in couple. So I decided move
them both, to be more consistent, to make code less complicated.
If you regard this hazardous I might split these removals. But IMHO, my
variant is a bit more pleasant.
> Retest, and resend.
Thanks.
I assume I don't need to notify Andrew about the inconsistency in the
old patch, or should I?
--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.
next prev parent reply other threads:[~2005-04-28 7:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 13:15 [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between Artem B. Bityuckiy
2005-04-27 13:42 ` Jan Harkes
2005-04-27 14:22 ` Miklos Szeredi
2005-04-27 15:57 ` Miklos Szeredi
2005-04-27 16:19 ` Artem B. Bityuckiy
[not found] ` <E1DQqZu-0002Rf-00@dorka.pomaz.szeredi.hu>
2005-04-28 7:32 ` Artem B. Bityuckiy [this message]
2005-04-28 7:34 ` Andrew Morton
2005-05-04 12:17 ` Artem B. Bityuckiy
2005-05-04 20:04 ` Andrew Morton
2005-05-04 21:35 ` David Woodhouse
2005-05-04 21:58 ` Andrew Morton
2005-05-05 9:10 ` David Woodhouse
2005-05-05 16:18 ` Miklos Szeredi
2005-05-06 11:08 ` David Woodhouse
2005-06-13 14:45 ` Synchronous FAT Artem B. Bityuckiy
2005-06-14 1:06 ` Coywolf Qi Hunt
2005-06-14 12:16 ` Artem B. Bityuckiy
2005-06-15 1:19 ` Coywolf Qi Hunt
2005-04-28 7:41 ` [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between Miklos Szeredi
2005-04-28 7:47 ` Artem B. Bityuckiy
-- strict thread matches above, loose matches on Subject: below --
2005-04-19 12:38 Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114673528.3483.2.camel@sauron.oktetlabs.ru \
--to=dedekind@infradead.org \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).